summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Catanzaro <mcatanzaro@igalia.com>2019-04-29 21:39:45 +0000
committerMichael Catanzaro <mcatanzaro@posteo.net>2019-05-15 21:14:42 +0000
commit06338f714f797b9fd1799386eb89b0c5be5a0f32 (patch)
tree7480dc4cce7628d2ce54d515d672d824c83043ac
parent2a2dddcb8f4ef7386a0d06ebd56bca5ddb2f8960 (diff)
downloadepiphany-06338f714f797b9fd1799386eb89b0c5be5a0f32.tar.gz
history-manager: avoid critical when deleting URLs not tracked by sync
Fixes #691 (cherry picked from commit 7e7aa0fbd26147bb2b0aadd1e67fb3f65d9937e6) (cherry picked from commit 7be86b8b66afa396f6c0a94ee9dd75f16f924acb) (cherry picked from commit 4ded92136d69ae119077166776b0b92770e73ddf)
-rw-r--r--lib/sync/ephy-history-manager.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/lib/sync/ephy-history-manager.c b/lib/sync/ephy-history-manager.c
index 3983b5a43..8a2578964 100644
--- a/lib/sync/ephy-history-manager.c
+++ b/lib/sync/ephy-history-manager.c
@@ -91,6 +91,9 @@ url_visited_cb (EphyHistoryService *service,
{
EphyHistoryRecord *record;
+ if (!url->sync_id)
+ return;
+
record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
g_signal_emit_by_name (self, "synchronizable-modified", record, TRUE);
g_object_unref (record);
@@ -103,6 +106,9 @@ url_deleted_cb (EphyHistoryService *service,
{
EphyHistoryRecord *record;
+ if (!url->sync_id)
+ return;
+
record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
g_signal_emit_by_name (self, "synchronizable-deleted", record);
g_object_unref (record);