From b0a83ae71b2588bd2a9e6b40f95191602940e01e Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Thu, 7 Nov 2019 09:53:41 +0100 Subject: login: Remove double-assignment of fl.l_whence in try_file_lock Since l_whence is the second member of struct flock, it is written twice. The double-assignment is technically undefined behavior due to the lack of a sequence point. Reviewed-by: Carlos O'Donell Change-Id: I2baf9e70690e723c61051b25ccbd510aec15976c --- login/utmp_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/login/utmp_file.c b/login/utmp_file.c index be7cc0671b..e627233478 100644 --- a/login/utmp_file.c +++ b/login/utmp_file.c @@ -79,7 +79,7 @@ try_file_lock (int fd, int type) struct flock64 fl = { .l_type = type, - fl.l_whence = SEEK_SET, + .l_whence = SEEK_SET, }; bool status = __fcntl64_nocancel (fd, F_SETLKW, &fl) < 0; -- cgit v1.2.1