delta/glibc.git/string, branch ibm/2.32/master sourceware.org: git/glibc.git string: Add a testcase for wcsncmp with SIZE_MAX [BZ #28755] 2022-02-17T19:32:14+00:00 H.J. Lu hjl.tools@gmail.com 2022-02-17T16:10:35+00:00 0f8a2390000c4e9a152b5f6cf8220f2560c01e74 Verify that wcsncmp (L("abc"), L("abd"), SIZE_MAX) == 0. The new test fails without commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87 Author: Noah Goldstein <goldstein.w.n@gmail.com> Date: Sun Jan 9 16:02:21 2022 -0600 x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755] and commit 7e08db3359c86c94918feb33a1182cd0ff3bb10b Author: Noah Goldstein <goldstein.w.n@gmail.com> Date: Sun Jan 9 16:02:28 2022 -0600 x86: Fix __wcsncmp_evex in strcmp-evex.S [BZ# 28755] This is for BZ #28755. Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com> (cherry picked from commit aa5a720056d37cf24924c138a3dbe6dace98e97c) 
Verify that wcsncmp (L("abc"), L("abd"), SIZE_MAX) == 0.  The new test
fails without

commit ddf0992cf57a93200e0c782e2a94d0733a5a0b87
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Sun Jan 9 16:02:21 2022 -0600

    x86: Fix __wcsncmp_avx2 in strcmp-avx2.S [BZ# 28755]

and

commit 7e08db3359c86c94918feb33a1182cd0ff3bb10b
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Sun Jan 9 16:02:28 2022 -0600

    x86: Fix __wcsncmp_evex in strcmp-evex.S [BZ# 28755]

This is for BZ #28755.

Reviewed-by: Sunil K Pandey <skpgkp2@gmail.com>

(cherry picked from commit aa5a720056d37cf24924c138a3dbe6dace98e97c)
String: Add overflow tests for strnlen, memchr, and strncat [BZ #27974] 2022-01-27T22:45:39+00:00 Noah Goldstein goldstein.w.n@gmail.com 2021-06-09T20:17:14+00:00 63c84a82a3633560038c2d8863bb07756dc9580d This commit adds tests for a bug in the wide char variant of the functions where the implementation may assume that maxlen for wcsnlen or n for wmemchr/strncat will not overflow when multiplied by sizeof(wchar_t). These tests show the following implementations failing on x86_64: wcsnlen-sse4_1 wcsnlen-avx2 wmemchr-sse2 wmemchr-avx2 strncat would fail as well if it where on a system that prefered either of the wcsnlen implementations that failed as it relies on wcsnlen. Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com> Reviewed-by: H.J. Lu <hjl.tools@gmail.com> (cherry picked from commit da5a6fba0febbfc90896ce1b2eb75c6d8a88a72d) 
This commit adds tests for a bug in the wide char variant of the
functions where the implementation may assume that maxlen for wcsnlen
or n for wmemchr/strncat will not overflow when multiplied by
sizeof(wchar_t).

These tests show the following implementations failing on x86_64:

wcsnlen-sse4_1
wcsnlen-avx2

wmemchr-sse2
wmemchr-avx2

strncat would fail as well if it where on a system that prefered
either of the wcsnlen implementations that failed as it relies on
wcsnlen.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
(cherry picked from commit da5a6fba0febbfc90896ce1b2eb75c6d8a88a72d)
test-strnlen.c: Check that strnlen won't go beyond the maximum length 2022-01-27T22:42:27+00:00 H.J. Lu hjl.tools@gmail.com 2021-03-27T16:06:39+00:00 33046deb9626e35b587db9e722111a450f952e44 Place strings ending at page boundary without the null byte. If an implementation goes beyond EXP_LEN, it will trigger the segfault. (cherry picked from commit cb882b21b63606aabd6e55afe23b42434d95f2ef) 
Place strings ending at page boundary without the null byte.  If an
implementation goes beyond EXP_LEN, it will trigger the segfault.

(cherry picked from commit cb882b21b63606aabd6e55afe23b42434d95f2ef)
test-strnlen.c: Initialize wchar_t string with wmemset [BZ #27655] 2022-01-27T22:42:22+00:00 H.J. Lu hjl.tools@gmail.com 2021-03-27T16:15:00+00:00 e218418d4925972ab7979b1712ec15d0cb645b76 Use wmemset to initialize wchar_t string. (cherry picked from commit 86859b7e58d8670b186c5209ba25f0fbd6612fb7) 
Use wmemset to initialize wchar_t string.

(cherry picked from commit 86859b7e58d8670b186c5209ba25f0fbd6612fb7)
Remove __warn_memset_zero_len [BZ #25399] 2020-11-10T14:31:01+00:00 Siddhesh Poyarekar siddhesh@sourceware.org 2020-11-03T09:39:28+00:00 5337b2af4b863fc9a1b92134bbe09758f1eff39d Non-gcc compilers (clang and possibly other compilers that do not masquerade as gcc 5.0 or later) are unable to use __warn_memset_zero_len since the symbol is no longer available on glibc built with gcc 5.0 or later. While it was likely an oversight that caused this omission, the fact that it wasn't noticed until recently (when clang closed the gap on _FORTIFY_SUPPORT) that the symbol was missing. Given that both gcc and clang are capable of doing this check in the compiler, drop all remaining signs of __warn_memset_zero_len from glibc so that no more objects are built with this symbol in future. (cherry-picked from dc274b141666766b8ef70992d887e3c0c5e41bed) 
Non-gcc compilers (clang and possibly other compilers that do not
masquerade as gcc 5.0 or later) are unable to use
__warn_memset_zero_len since the symbol is no longer available on
glibc built with gcc 5.0 or later.  While it was likely an oversight
that caused this omission, the fact that it wasn't noticed until
recently (when clang closed the gap on _FORTIFY_SUPPORT) that the
symbol was missing.

Given that both gcc and clang are capable of doing this check in the
compiler, drop all remaining signs of __warn_memset_zero_len from
glibc so that no more objects are built with this symbol in future.

(cherry-picked from dc274b141666766b8ef70992d887e3c0c5e41bed)
string: Make tst-strerror/tst-strsignal unsupported if msgfmt is not installed 2020-07-13T12:16:11+00:00 Adhemerval Zanella adhemerval.zanella@linaro.org 2020-07-09T16:24:04+00:00 10b01bd4529336bffc2c398ce43a171ed94aacc7 Without msgfmt libc.mo files are not generated and its loading failure is silent ignored with xsetlocale. Also unset LANGUAGE environment variable to avoid it taking precedence when loading the message catalog. Although not strictly required (since the test is issued with test-container and it sets a strict environment variable) it follows other tests that deal with translation. Checked on x86_64-linux-gnu. 
Without msgfmt libc.mo files are not generated and its loading failure
is silent ignored with xsetlocale.

Also unset LANGUAGE environment variable to avoid it taking precedence
when loading the message catalog.  Although not strictly required
(since the test is issued with test-container and it sets a strict
environment variable) it follows other tests that deal with
translation.

Checked on x86_64-linux-gnu.
string: Move tst-strsignal tst-strerror to tests-container 2020-07-08T13:23:14+00:00 Adhemerval Zanella adhemerval.zanella@linaro.org 2020-07-08T13:23:14+00:00 c1e63c7214aaef99039068da384a0ab3abc176f2 Both tests require libc.mo translation files which might not be installed on the system. Checked on x86_64-linux-gnu. 
Both tests require libc.mo translation files which might not be
installed on the system.

Checked on x86_64-linux-gnu.
string: Fix prototype mismatch in sigabbrev_np, __sigdescr_np 2020-07-08T12:19:58+00:00 Florian Weimer fweimer@redhat.com 2020-07-08T12:19:58+00:00 5b2deed8a5d5cca2d82423572415a1c629bea488 GCC 6 does not ignore the const specifier on the return type. 
GCC 6 does not ignore the const specifier on the return type.
tst-strsignal: fix checking for RT signals support 2020-07-07T21:24:50+00:00 Samuel Thibault samuel.thibault@ens-lyon.org 2020-07-07T21:24:48+00:00 5549370a73c45b12621a1abe58920771278a72b4 * string/tst-strsignal.c (do_test): Actually check that RT signals are available by comparing SIGRTMAX to SIGRTMIN. Check that SIGRTMAX is 64 before testing for a message reporting 65 for SIGRTMAX+1. 
* string/tst-strsignal.c (do_test): Actually check that RT signals are
available by comparing SIGRTMAX to SIGRTMIN. Check that SIGRTMAX is 64
before testing for a message reporting 65 for SIGRTMAX+1.
string: Add strerrorname_np and strerrordesc_np 2020-07-07T18:02:57+00:00 Adhemerval Zanella adhemerval.zanella@linaro.org 2020-05-18T20:41:25+00:00 325081b9eb2035f8f025255206889208f330b590 The strerrorname_np returns error number name (e.g. "EINVAL" for EINVAL) while strerrordesc_np returns string describing error number (e.g "Invalid argument" for EINVAL). Different than strerror, strerrordesc_np does not attempt to translate the return description, both functions return NULL for an invalid error number. They should be used instead of sys_errlist and sys_nerr, both are thread and async-signal safe. These functions are GNU extensions. Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, and s390x-linux-gnu. Tested-by: Carlos O'Donell <carlos@redhat.com> Reviewed-by: Carlos O'Donell <carlos@redhat.com> 
The strerrorname_np returns error number name (e.g. "EINVAL" for EINVAL)
while strerrordesc_np returns string describing error number (e.g
"Invalid argument" for EINVAL).  Different than strerror,
strerrordesc_np does not attempt to translate the return description,
both functions return NULL for an invalid error number.

They should be used instead of sys_errlist and sys_nerr, both are
thread and async-signal safe.  These functions are GNU extensions.

Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu,
and s390x-linux-gnu.

Tested-by: Carlos O'Donell <carlos@redhat.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>