<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/glib.git/tests/mainloop-test.c, branch pgriffis/wip/resolver-https</title>
<subtitle>gitlab.gnome.org: GNOME/glib.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/'/>
<entry>
<title>Port internal uses to use g_source_set_static_name()</title>
<updated>2021-07-26T10:01:07+00:00</updated>
<author>
<name>Philip Withnall</name>
<email>pwithnall@endlessos.org</email>
</author>
<published>2021-07-26T09:53:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=8e963e0e317b02c4f912d8b989c75707a48aba6f'/>
<id>8e963e0e317b02c4f912d8b989c75707a48aba6f</id>
<content type='text'>
This should reduce allocations.

Signed-off-by: Philip Withnall &lt;pwithnall@endlessos.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This should reduce allocations.

Signed-off-by: Philip Withnall &lt;pwithnall@endlessos.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix signedness warning in tests/mainloop-test.c</title>
<updated>2021-05-04T06:46:10+00:00</updated>
<author>
<name>Emmanuel Fleury</name>
<email>emmanuel.fleury@gmail.com</email>
</author>
<published>2020-11-20T21:00:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=c339e29d465ca2b105f93d95a8726e270581c47a'/>
<id>c339e29d465ca2b105f93d95a8726e270581c47a</id>
<content type='text'>
tests/mainloop-test.c: In function ‘cleanup_crawlers’:
tests/mainloop-test.c:358:15: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’}
  358 |   for (i=0; i &lt; crawler_array-&gt;len; i++)
      |               ^
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tests/mainloop-test.c: In function ‘cleanup_crawlers’:
tests/mainloop-test.c:358:15: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’}
  358 |   for (i=0; i &lt; crawler_array-&gt;len; i++)
      |               ^
</pre>
</div>
</content>
</entry>
<entry>
<title>mainloop-test: Fix race conditions</title>
<updated>2018-10-29T23:55:14+00:00</updated>
<author>
<name>Tomasz Miąsko</name>
<email>tomasz.miasko@gmail.com</email>
</author>
<published>2018-10-30T00:00:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=88f36a1d6fde83278b571307dc49e7d56d94411f'/>
<id>88f36a1d6fde83278b571307dc49e7d56d94411f</id>
<content type='text'>
* Wait for adder threads before deallocating crawler_array and
  context_array to avoid use after-free and data race.
* Handle spurious wakeups around g_cond_wait.
* Avoid starting recurser_idle without context.

Fixes issue #1530.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
* Wait for adder threads before deallocating crawler_array and
  context_array to avoid use after-free and data race.
* Handle spurious wakeups around g_cond_wait.
* Avoid starting recurser_idle without context.

Fixes issue #1530.
</pre>
</div>
</content>
</entry>
<entry>
<title>all: Remove trailing newlines from g_message()/g_warning()/g_error()s</title>
<updated>2018-04-27T15:46:19+00:00</updated>
<author>
<name>Philip Withnall</name>
<email>withnall@endlessm.com</email>
</author>
<published>2018-04-27T15:45:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=9b4c50f63d9ef7c2033777a95a743009f0a145a1'/>
<id>9b4c50f63d9ef7c2033777a95a743009f0a145a1</id>
<content type='text'>
All those logging functions already add a newline to any message they
print, so there’s no need to add a trailing newline in the message
passed to them.

Signed-off-by: Philip Withnall &lt;withnall@endlessm.com&gt;
Reviewed-by: nobody
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All those logging functions already add a newline to any message they
print, so there’s no need to add a trailing newline in the message
passed to them.

Signed-off-by: Philip Withnall &lt;withnall@endlessm.com&gt;
Reviewed-by: nobody
</pre>
</div>
</content>
</entry>
<entry>
<title>Consistently save errno immediately after the operation setting it</title>
<updated>2017-08-03T09:21:13+00:00</updated>
<author>
<name>Philip Withnall</name>
<email>withnall@endlessm.com</email>
</author>
<published>2017-07-31T10:30:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=5cddde1fb2b8466d8104595008eafabd0728de5d'/>
<id>5cddde1fb2b8466d8104595008eafabd0728de5d</id>
<content type='text'>
Prevent the situation where errno is set by function A, then function B
is called (which is typically _(), but could be anything else) and it
overwrites errno, then errno is checked by the caller.

errno is a horrific API, and we need to be careful to save its value as
soon as a function call (which might set it) returns. i.e. Follow the
pattern:
  int errsv, ret;
  ret = some_call_which_might_set_errno ();
  errsv = errno;

  if (ret &lt; 0)
    puts (strerror (errsv));

This patch implements that pattern throughout GLib. There might be a few
places in the test code which still use errno directly. They should be
ported as necessary. It doesn’t modify all the call sites like this:
  if (some_call_which_might_set_errno () &amp;&amp; errno == ESOMETHING)
since the refactoring involved is probably more harmful than beneficial
there. It does, however, refactor other call sites regardless of whether
they were originally buggy.

https://bugzilla.gnome.org/show_bug.cgi?id=785577
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Prevent the situation where errno is set by function A, then function B
is called (which is typically _(), but could be anything else) and it
overwrites errno, then errno is checked by the caller.

errno is a horrific API, and we need to be careful to save its value as
soon as a function call (which might set it) returns. i.e. Follow the
pattern:
  int errsv, ret;
  ret = some_call_which_might_set_errno ();
  errsv = errno;

  if (ret &lt; 0)
    puts (strerror (errsv));

This patch implements that pattern throughout GLib. There might be a few
places in the test code which still use errno directly. They should be
ported as necessary. It doesn’t modify all the call sites like this:
  if (some_call_which_might_set_errno () &amp;&amp; errno == ESOMETHING)
since the refactoring involved is probably more harmful than beneficial
there. It does, however, refactor other call sites regardless of whether
they were originally buggy.

https://bugzilla.gnome.org/show_bug.cgi?id=785577
</pre>
</div>
</content>
</entry>
<entry>
<title>mainloop-test: Fix uninitialized memory access in tests</title>
<updated>2013-11-11T16:35:26+00:00</updated>
<author>
<name>Stef Walter</name>
<email>stefw@gnome.org</email>
</author>
<published>2013-11-09T19:26:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=3e041ce5adde83a44f6f5156c7463157539ddbc4'/>
<id>3e041ce5adde83a44f6f5156c7463157539ddbc4</id>
<content type='text'>
https://bugzilla.gnome.org/show_bug.cgi?id=711751
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.gnome.org/show_bug.cgi?id=711751
</pre>
</div>
</content>
</entry>
<entry>
<title>mainloop-test: Fix leaks in tests</title>
<updated>2013-11-10T21:43:25+00:00</updated>
<author>
<name>Stef Walter</name>
<email>stefw@gnome.org</email>
</author>
<published>2013-11-09T19:30:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=ae1764b4e0dd33d55fac8a5329b0c5d45c4c66fd'/>
<id>ae1764b4e0dd33d55fac8a5329b0c5d45c4c66fd</id>
<content type='text'>
https://bugzilla.gnome.org/show_bug.cgi?id=711751
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.gnome.org/show_bug.cgi?id=711751
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove a bunch of lingering g_thread_init()</title>
<updated>2013-06-01T03:03:19+00:00</updated>
<author>
<name>Ryan Lortie</name>
<email>desrt@desrt.ca</email>
</author>
<published>2013-05-30T04:04:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=210b1f8b4230b881d1c2e4a9e7dac571c967e091'/>
<id>210b1f8b4230b881d1c2e4a9e7dac571c967e091</id>
<content type='text'>
After this patch, there is but one remaining use of g_thread_init(),
which is in tests/slice-threadinit.c, a testcase dedicated to testing
the functionality of gslice across a g_thread_init() boundary.

This testcase is pretty meaningless these days... probably we should
delete it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After this patch, there is but one remaining use of g_thread_init(),
which is in tests/slice-threadinit.c, a testcase dedicated to testing
the functionality of gslice across a g_thread_init() boundary.

This testcase is pretty meaningless these days... probably we should
delete it.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix more warning-addition fallout</title>
<updated>2012-11-02T16:27:19+00:00</updated>
<author>
<name>Simon McVittie</name>
<email>simon.mcvittie@collabora.co.uk</email>
</author>
<published>2012-11-02T15:45:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=837db1a026a451f2785be18593bf3fa631acabd6'/>
<id>837db1a026a451f2785be18593bf3fa631acabd6</id>
<content type='text'>
I'm normally a big fan of small atomic commits, but I also want to get
things done this afternoon...

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687441
Reviewed-by: Colin Walters &lt;walters@verbum.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I'm normally a big fan of small atomic commits, but I also want to get
things done this afternoon...

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687441
Reviewed-by: Colin Walters &lt;walters@verbum.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove g_mutex_new()/g_cond_new() in testcases</title>
<updated>2011-10-04T23:35:27+00:00</updated>
<author>
<name>Ryan Lortie</name>
<email>desrt@desrt.ca</email>
</author>
<published>2011-10-04T23:04:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=6f343ca548af912e7ea6b0a35f5e12c8cb820126'/>
<id>6f343ca548af912e7ea6b0a35f5e12c8cb820126</id>
<content type='text'>
These were the last users of the dynamic allocation API.

Keep the uses in glib/tests/mutex.c since this is actually meant to test
the API (which has to continue working, even if it is deprecated).

https://bugzilla.gnome.org/show_bug.cgi?id=660739
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These were the last users of the dynamic allocation API.

Keep the uses in glib/tests/mutex.c since this is actually meant to test
the API (which has to continue working, even if it is deprecated).

https://bugzilla.gnome.org/show_bug.cgi?id=660739
</pre>
</div>
</content>
</entry>
</feed>
