<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/glib.git/gio/kqueue, branch require-python34</title>
<subtitle>gitlab.gnome.org: GNOME/glib.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/'/>
<entry>
<title>Merge branch 'wip/lantw/freebsd-kqueue-complex' into 'master'</title>
<updated>2018-06-19T11:19:43+00:00</updated>
<author>
<name>Philip Withnall</name>
<email>philip@tecnocode.co.uk</email>
</author>
<published>2018-06-19T11:19:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=40a84b3d1ce255fb8508f0acd6379b6f19b7c156'/>
<id>40a84b3d1ce255fb8508f0acd6379b6f19b7c156</id>
<content type='text'>
FreeBSD kqueue file monitor fixes: the complex parts

See merge request GNOME/glib!77</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
FreeBSD kqueue file monitor fixes: the complex parts

See merge request GNOME/glib!77</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Use the worker context to schedule rescanning of missing files</title>
<updated>2018-06-17T03:26:32+00:00</updated>
<author>
<name>Ting-Wei Lan</name>
<email>lantw@src.gnome.org</email>
</author>
<published>2018-06-17T01:48:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=e714e1e951844ec7366417f082d017b32ac7927b'/>
<id>e714e1e951844ec7366417f082d017b32ac7927b</id>
<content type='text'>
This makes it consistent with the file monitor itself, which already
attaches kqueue event sources to the worker context.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This makes it consistent with the file monitor itself, which already
attaches kqueue event sources to the worker context.
</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Make it possible to pass file monitor tests</title>
<updated>2018-06-17T03:26:32+00:00</updated>
<author>
<name>Ting-Wei Lan</name>
<email>lantw@src.gnome.org</email>
</author>
<published>2018-06-03T11:35:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=09c019a4f03c7a57aa8048479824104e8d3b3870'/>
<id>09c019a4f03c7a57aa8048479824104e8d3b3870</id>
<content type='text'>
Previously, kqueue file monitor only add event sources for directories
regardless of the type of the file being monitored. Doing so may be
possible on inotify, but it is not sufficient on kqueue. Watching a
directory on kqueue doesn't report changes made to files under it, and
we must watch files themselves to get notified. This problem is fixed
by adding a second watch for non-directory file monitors, and the result
is that we are now able to receive 'CHANGED' and 'ATTRIBUTE_CHANGED'
events for non-directory files.

Since having two watches on one file monitor requires many code changes
to work properly, this commit also changes the following things:

 - NOTE_ALL macro is now replaced by note_all inline function. Since the
   kqueue backend is shared by all BSD operating systems, there are a
   few difference between these systems. It is easier to do '#ifdef'
   check in a function than in a macro.

 - Both g_kqueue_file_monitor_callback and g_kqueue_file_monitor_cancel
   now holds a lock before accessing kqueue_sub structs. This fixes a
   crash when these two functions are called from different threads,
   causing g_kqueue_file_monitor_callback to access freed memory.

 - 'mask' variable in g_kqueue_file_monitor_callback is now removed.
   The usage of 'mask' was wrong because of the 'mask &gt; 0' check.
   'CHANGED' event has value 0 so the 'mask &gt; 0' check made it
   impossible to emit 'CHANGED' events.

 - kqueue-missing scans can now be triggered from the kqueue event
   callback instead of always waiting for 4 seconds.

 - Don't remove a file from kqueue on unlink unless its hard link count
   has dropped to zero.

 - Don't use 'else if' in the check of 'fflags'. It is possible for a
   kevent to have multiple flags set.

 - Don't use g_file_monitor_emit_event directly. Always use
   g_file_monitor_source_handle_event to report events.
   Events submitted to g_file_monitor_emit_event are delivered
   immediately, but events sent to g_file_monitor_source_handle_event
   are scheduled by GLocalFileMonitor. If we mix the two, the order of
   events will be wrong and tests will fail.

 - Report 'CHANGES_DONE_HINT' immediately after 'CREATED' if the file
   created is not a regular file. This is copied from ih_event_callback.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, kqueue file monitor only add event sources for directories
regardless of the type of the file being monitored. Doing so may be
possible on inotify, but it is not sufficient on kqueue. Watching a
directory on kqueue doesn't report changes made to files under it, and
we must watch files themselves to get notified. This problem is fixed
by adding a second watch for non-directory file monitors, and the result
is that we are now able to receive 'CHANGED' and 'ATTRIBUTE_CHANGED'
events for non-directory files.

Since having two watches on one file monitor requires many code changes
to work properly, this commit also changes the following things:

 - NOTE_ALL macro is now replaced by note_all inline function. Since the
   kqueue backend is shared by all BSD operating systems, there are a
   few difference between these systems. It is easier to do '#ifdef'
   check in a function than in a macro.

 - Both g_kqueue_file_monitor_callback and g_kqueue_file_monitor_cancel
   now holds a lock before accessing kqueue_sub structs. This fixes a
   crash when these two functions are called from different threads,
   causing g_kqueue_file_monitor_callback to access freed memory.

 - 'mask' variable in g_kqueue_file_monitor_callback is now removed.
   The usage of 'mask' was wrong because of the 'mask &gt; 0' check.
   'CHANGED' event has value 0 so the 'mask &gt; 0' check made it
   impossible to emit 'CHANGED' events.

 - kqueue-missing scans can now be triggered from the kqueue event
   callback instead of always waiting for 4 seconds.

 - Don't remove a file from kqueue on unlink unless its hard link count
   has dropped to zero.

 - Don't use 'else if' in the check of 'fflags'. It is possible for a
   kevent to have multiple flags set.

 - Don't use g_file_monitor_emit_event directly. Always use
   g_file_monitor_source_handle_event to report events.
   Events submitted to g_file_monitor_emit_event are delivered
   immediately, but events sent to g_file_monitor_source_handle_event
   are scheduled by GLocalFileMonitor. If we mix the two, the order of
   events will be wrong and tests will fail.

 - Report 'CHANGES_DONE_HINT' immediately after 'CREATED' if the file
   created is not a regular file. This is copied from ih_event_callback.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'wip/lantw/freebsd-meson-builds' into 'master'</title>
<updated>2018-06-11T10:53:10+00:00</updated>
<author>
<name>Philip Withnall</name>
<email>philip@tecnocode.co.uk</email>
</author>
<published>2018-06-11T10:53:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=262b153c411b21d93819fe10c6702ef89da24f11'/>
<id>262b153c411b21d93819fe10c6702ef89da24f11</id>
<content type='text'>
Fix meson build files for FreeBSD

See merge request GNOME/glib!73</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix meson build files for FreeBSD

See merge request GNOME/glib!73</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Only fallback to polling on /media and /run/media</title>
<updated>2018-06-06T16:38:07+00:00</updated>
<author>
<name>Ting-Wei Lan</name>
<email>lantw@src.gnome.org</email>
</author>
<published>2018-06-03T04:15:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=41259ac173143fbb06bc07dab80fbe06493716df'/>
<id>41259ac173143fbb06bc07dab80fbe06493716df</id>
<content type='text'>
The check in _ke_is_excluded, which causes GKqueueFileMonitor to
fallback to GPollFileMonitor when it returns TRUE, was made to prevent
file monitor from blocking unmount of removable drives on systems not
supporting O_EVTONLY flag in open. However, since g_mount_can_unmount
always returns TRUE on Unix-like platforms, the check always returns
TRUE on non-standard mount points, which is very likely to cause all
programs on the desktop to use the polling fallback if GNOME is
installed in a different prefix for development. This makes the desktop
sluggish and results in bad developer experience on *BSD.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The check in _ke_is_excluded, which causes GKqueueFileMonitor to
fallback to GPollFileMonitor when it returns TRUE, was made to prevent
file monitor from blocking unmount of removable drives on systems not
supporting O_EVTONLY flag in open. However, since g_mount_can_unmount
always returns TRUE on Unix-like platforms, the check always returns
TRUE on non-standard mount points, which is very likely to cause all
programs on the desktop to use the polling fallback if GNOME is
installed in a different prefix for development. This makes the desktop
sluggish and results in bad developer experience on *BSD.
</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Make _ke_is_excluded static</title>
<updated>2018-06-06T16:34:36+00:00</updated>
<author>
<name>Ting-Wei Lan</name>
<email>lantw@src.gnome.org</email>
</author>
<published>2018-05-24T15:37:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=038836735620c51d86db70386182ff00e325ede4'/>
<id>038836735620c51d86db70386182ff00e325ede4</id>
<content type='text'>
It is not used in any other file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It is not used in any other file.
</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Fix typo that breaks the build in previous commit</title>
<updated>2018-05-18T14:52:08+00:00</updated>
<author>
<name>Xavier Claessens</name>
<email>xavier.claessens@collabora.com</email>
</author>
<published>2018-05-18T14:49:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=41e008266dfd489f6c7906af9414cb3ff5bb660f'/>
<id>41e008266dfd489f6c7906af9414cb3ff5bb660f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue: Fix -Wdeclaration-after-statement errors</title>
<updated>2018-05-18T14:09:24+00:00</updated>
<author>
<name>Xavier Claessens</name>
<email>xavier.claessens@collabora.com</email>
</author>
<published>2018-05-17T17:25:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=5b19df2f44d5d2a21d00c10aa41f826bd29ebe6b'/>
<id>5b19df2f44d5d2a21d00c10aa41f826bd29ebe6b</id>
<content type='text'>
https://bugzilla.gnome.org/show_bug.cgi?id=796213
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://bugzilla.gnome.org/show_bug.cgi?id=796213
</pre>
</div>
</content>
</entry>
<entry>
<title>kqueue/meson: add missing dependency</title>
<updated>2018-05-02T23:01:50+00:00</updated>
<author>
<name>Havard Graff</name>
<email>havard.graff@gmail.com</email>
</author>
<published>2018-03-14T19:50:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=71fba3b3be451f0371d4adb5a28d0e8b939baeed'/>
<id>71fba3b3be451f0371d4adb5a28d0e8b939baeed</id>
<content type='text'>
gioenumtypes needs to be generated:
In file included from ../../../../external/glib/gio/kqueue/gkqueuefilemonitor.c:37:
In file included from ../../../../external/./glib/gio/glocalfilemonitor.h:25:
In file included from ../../../../external/./glib/gio/gunixmounts.h:24:
../../../../external/./glib/gio/gio.h:86:10: fatal error: 'gio/gioenumtypes.h' file not found
#include &lt;gio/gioenumtypes.h&gt;
         ^~~~~~~~~~~~~~~~~~~~

https://bugzilla.gnome.org/show_bug.cgi?id=794325
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
gioenumtypes needs to be generated:
In file included from ../../../../external/glib/gio/kqueue/gkqueuefilemonitor.c:37:
In file included from ../../../../external/./glib/gio/glocalfilemonitor.h:25:
In file included from ../../../../external/./glib/gio/gunixmounts.h:24:
../../../../external/./glib/gio/gio.h:86:10: fatal error: 'gio/gioenumtypes.h' file not found
#include &lt;gio/gioenumtypes.h&gt;
         ^~~~~~~~~~~~~~~~~~~~

https://bugzilla.gnome.org/show_bug.cgi?id=794325
</pre>
</div>
</content>
</entry>
<entry>
<title>Reorder operations in _kqsub_cancel() to prevent races.</title>
<updated>2018-04-23T19:07:55+00:00</updated>
<author>
<name>Martin Pieuchot</name>
<email>mpi@openbsd.org</email>
</author>
<published>2018-04-11T15:58:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/glib.git/commit/?id=ab179184b883ad378a420223f378071821f0c8b9'/>
<id>ab179184b883ad378a420223f378071821f0c8b9</id>
<content type='text'>
Removing the event and closing the related file descriptor must be
done first to make sure the kqueue subsystem delete pending events.

The timeout must be disarmed before freeing the directory dependency
list otherwise it might populate it again.

https://bugzilla.gnome.org/show_bug.cgi?id=795193
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Removing the event and closing the related file descriptor must be
done first to make sure the kqueue subsystem delete pending events.

The timeout must be disarmed before freeing the directory dependency
list otherwise it might populate it again.

https://bugzilla.gnome.org/show_bug.cgi?id=795193
</pre>
</div>
</content>
</entry>
</feed>
