From b4f6fbd8cba3e7678462e68e6fc63df23b763187 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Tue, 27 Nov 2018 13:42:10 -0800 Subject: Remove circular dependency between HTTPHelper and GitlabNet HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet included HttpHelper. Specs in Ruby 2.5 were breaking as a result of Action::Custom not able to reference constants in GitLabNet: https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169 --- lib/http_helper.rb | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/http_helper.rb') diff --git a/lib/http_helper.rb b/lib/http_helper.rb index b2a6211..c66df53 100644 --- a/lib/http_helper.rb +++ b/lib/http_helper.rb @@ -1,5 +1,6 @@ require_relative 'httpunix' require_relative 'gitlab_logger' +require_relative 'gitlab_net/errors' module HTTPHelper READ_TIMEOUT = 300 -- cgit v1.2.1