From b4f6fbd8cba3e7678462e68e6fc63df23b763187 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Tue, 27 Nov 2018 13:42:10 -0800 Subject: Remove circular dependency between HTTPHelper and GitlabNet HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet included HttpHelper. Specs in Ruby 2.5 were breaking as a result of Action::Custom not able to reference constants in GitLabNet: https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169 --- lib/gitlab_net/errors.rb | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 lib/gitlab_net/errors.rb (limited to 'lib/gitlab_net') diff --git a/lib/gitlab_net/errors.rb b/lib/gitlab_net/errors.rb new file mode 100644 index 0000000..f32b3d8 --- /dev/null +++ b/lib/gitlab_net/errors.rb @@ -0,0 +1,4 @@ +class GitlabNet + class ApiUnreachableError < StandardError; end + class NotFound < StandardError; end +end -- cgit v1.2.1