From a85a32afd9788229d9f33dcbc13fc638e67fc549 Mon Sep 17 00:00:00 2001 From: Takuya Noguchi Date: Thu, 5 Nov 2020 13:27:20 +0000 Subject: Remove rubocop from Ruby test Signed-off-by: Takuya Noguchi --- .codeclimate.yml | 5 ---- .rubocop.yml | 73 -------------------------------------------------------- Gemfile | 1 - Gemfile.lock | 18 -------------- Makefile | 5 +--- README.md | 3 +-- 6 files changed, 2 insertions(+), 103 deletions(-) delete mode 100644 .rubocop.yml diff --git a/.codeclimate.yml b/.codeclimate.yml index 172b2e3..1c97bae 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -9,11 +9,6 @@ engines: - ruby fixme: enabled: true - rubocop: - enabled: true exclude_paths: -- spec/ -- lib/vendor/ -- go/vendor/ - tmp/ - coverage/ diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index 0c080ae..0000000 --- a/.rubocop.yml +++ /dev/null @@ -1,73 +0,0 @@ -# Exclude some of GitLab files -AllCops: - TargetRubyVersion: 2.3 - Exclude: - - 'spec/**/*' - - 'vendor/**/*' - - 'tmp/**/*' - - 'bin/**/*' - - 'hooks/**/*' - - 'Guardfile' - -Layout/DotPosition: - Enabled: false - -Lint/AmbiguousBlockAssociation: - Enabled: false - -Metrics/LineLength: - Enabled: false - -Metrics/MethodLength: - Enabled: false - -Metrics/BlockLength: - Enabled: false - -Metrics/ParameterLists: - Enabled: false - -Metrics/AbcSize: - Enabled: false - -Metrics/CyclomaticComplexity: - Enabled: false - -Metrics/PerceivedComplexity: - Enabled: false - -Style/Documentation: - Enabled: false - -Style/StringLiterals: - Enabled: false - -Style/StringLiterals: - Enabled: false - -Style/GlobalVars: - Enabled: false - -Style/AccessorMethodName: - Enabled: false - -Style/GuardClause: - Enabled: false - -Style/RescueModifier: - Enabled: false - -Style/PercentLiteralDelimiters: - Enabled: false - -Style/IfUnlessModifier: - Enabled: false - -Style/RegexpLiteral: - Enabled: false - -Style/SpecialGlobalVars: - Enabled: false - -Style/FrozenStringLiteralComment: - Enabled: false diff --git a/Gemfile b/Gemfile index 7a9efc1..5ed8fc4 100644 --- a/Gemfile +++ b/Gemfile @@ -2,5 +2,4 @@ source 'https://rubygems.org' group :development, :test do gem 'rspec', '~> 3.8.0' - gem 'rubocop', '0.49.1', require: false end diff --git a/Gemfile.lock b/Gemfile.lock index cddfc93..0a6c2cd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,15 +1,7 @@ GEM remote: https://rubygems.org/ specs: - ast (2.4.0) diff-lcs (1.3) - parallel (1.12.1) - parser (2.5.1.2) - ast (~> 2.4.0) - powerpack (0.1.2) - rainbow (2.2.2) - rake - rake (12.3.3) rspec (3.8.0) rspec-core (~> 3.8.0) rspec-expectations (~> 3.8.0) @@ -23,22 +15,12 @@ GEM diff-lcs (>= 1.2.0, < 2.0) rspec-support (~> 3.8.0) rspec-support (3.8.0) - rubocop (0.49.1) - parallel (~> 1.10) - parser (>= 2.3.3.1, < 3.0) - powerpack (~> 0.1) - rainbow (>= 1.99.1, < 3.0) - ruby-progressbar (~> 1.7) - unicode-display_width (~> 1.0, >= 1.0.1) - ruby-progressbar (1.9.0) - unicode-display_width (1.4.0) PLATFORMS ruby DEPENDENCIES rspec (~> 3.8.0) - rubocop (= 0.49.1) BUNDLED WITH 2.1.4 diff --git a/Makefile b/Makefile index 1c3fd38..749674b 100644 --- a/Makefile +++ b/Makefile @@ -7,10 +7,7 @@ GOBUILD_FLAGS := -ldflags "-X main.Version=$(VERSION_STRING) -X main.BuildTime=$ validate: verify test -verify: verify_ruby verify_golang - -verify_ruby: - bundle exec rubocop +verify: verify_golang verify_golang: gofmt -s -l $(GO_SOURCES) diff --git a/README.md b/README.md index 53fb37a..996a365 100644 --- a/README.md +++ b/README.md @@ -48,9 +48,8 @@ Run tests: bundle install make test -Run gofmt and rubocop: +Run gofmt: - bundle install make verify Run both test and verify (the default Makefile target): -- cgit v1.2.1