delta/gitlab/gitlab-shell.git/lib, branch sh-release-gitlab-shell-8-3-3

Merge branch 'sh-fix-nonatomic-puts' into 'master'

2018-09-12T12:38:00+00:00

Fix newlines not appearing between new log entries

Closes gitlab-com/gl-infra/infrastructure#5017

See merge request gitlab-org/gitlab-shell!242

Fix newlines not appearing between new log entries

2018-09-12T06:12:23+00:00

In https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5017, we
observed that lots of log messages were being dropped by Fluentd due to
missing newlines.

This occurs because there is a bug in Ruby where IO#puts calls write() twice:
once to write the main text, and another to write the newline
(https://bugs.ruby-lang.org/issues/14042). In a highly concurrent environment
like GitLab.com, this can lead to interleaved newlines.

A workaround is to use `IO#print` and append the newline ourselves.

Closes https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/5017

Ensure text/plain & text/html content typs are handled and add missing specs for handled HTTP status codes

2018-09-11T11:05:24+00:00

Only decode result body if it has content upon custom action failure

2018-09-07T22:03:13+00:00

Custom Action support

2018-09-07T14:52:57+00:00

GitlabAccessStatus needs HTTP response status code

2018-09-07T05:37:44+00:00

Use constants for git commands in GitlabShell

2018-09-07T05:37:44+00:00

New HTTPCodes module

2018-09-07T05:37:44+00:00

GitAccessStatus initializer sensible defaults

2018-09-07T05:37:14+00:00

Move some GitlabNet requires into HTTPHelper

2018-09-07T05:37:14+00:00