delta/gitlab/gitlab-shell.git/lib/gitlab_net, branch 181-migrate-gitlab-shell-checkers gitlab.com: gitlab-org/gitlab-shell.git Remove circular dependency between HTTPHelper and GitlabNet 2018-11-27T21:46:33+00:00 Stan Hu stanhu@gmail.com 2018-11-27T21:42:10+00:00 b4f6fbd8cba3e7678462e68e6fc63df23b763187 HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet included HttpHelper. Specs in Ruby 2.5 were breaking as a result of Action::Custom not able to reference constants in GitLabNet: https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169 
HttpHelper depended on exceptions defined in GitLabNet, but GitLabNet
included HttpHelper. Specs in Ruby 2.5 were breaking as a result of
Action::Custom not able to reference constants in GitLabNet:
https://gitlab.com/gitlab-org/gitlab-shell/-/jobs/126362702.

Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/169