<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git/internal, branch id-fix-flaky-test</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Refactor flaky test case in sshd_test</title>
<updated>2021-11-15T15:22:47+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-11-15T15:15:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=33180313d805212353d0526e3d95d49fe70eed91'/>
<id>33180313d805212353d0526e3d95d49fe70eed91</id>
<content type='text'>
- Use require.Regexp to expect ssh handshake error
- Use require.Eventually to refactor verifyStatus
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Use require.Regexp to expect ssh handshake error
- Use require.Eventually to refactor verifyStatus
</pre>
</div>
</content>
</entry>
<entry>
<title>Relax key and username matching for sshd</title>
<updated>2021-11-11T00:48:26+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2021-11-10T20:31:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=672013e702cb44c3bc1b46807703295448dc0afc'/>
<id>672013e702cb44c3bc1b46807703295448dc0afc</id>
<content type='text'>
Due to the way sshd works, gitlab-shell could be called with a single
string in the form:

```
/path/to/gitlab-shell -c key-id
```

However, due to the tightening of the regular expressions in fcff692b
this string no longer matches, so logins would fail with:

```
Failed to get username: who='' is invalid
```

This can be reproduced by changing the user's shell to point to
gitlab-shell. For example:

```
usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
```

While setting gitlab-shell as the user's shell isn't officially
supported, gitlab-shell still should be able to cope with the key being
specified as the last argument. We now split the argument list and use
the last value.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to the way sshd works, gitlab-shell could be called with a single
string in the form:

```
/path/to/gitlab-shell -c key-id
```

However, due to the tightening of the regular expressions in fcff692b
this string no longer matches, so logins would fail with:

```
Failed to get username: who='' is invalid
```

This can be reproduced by changing the user's shell to point to
gitlab-shell. For example:

```
usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
```

While setting gitlab-shell as the user's shell isn't officially
supported, gitlab-shell still should be able to cope with the key being
specified as the last argument. We now split the argument list and use
the last value.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
</pre>
</div>
</content>
</entry>
<entry>
<title>Add logging to RunGitalyCommand func</title>
<updated>2021-10-20T09:02:09+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-10-20T08:34:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=1dede51df96e9524b5519e115db5a0e1c719d03b'/>
<id>1dede51df96e9524b5519e115db5a0e1c719d03b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Log SSL_CERT_DIR when it's configured</title>
<updated>2021-10-20T09:02:09+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-10-20T08:33:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=f9f5423cf8d65c97d42991e218b990e5132fe293'/>
<id>f9f5423cf8d65c97d42991e218b990e5132fe293</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '499-log-non-git-commands' into 'main'</title>
<updated>2021-10-13T23:23:42+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2021-10-13T23:23:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=9dcfcd3a1d3001fb87b6e807f7fed31a05f509b2'/>
<id>9dcfcd3a1d3001fb87b6e807f7fed31a05f509b2</id>
<content type='text'>
Improve logging for non-git commands

See merge request gitlab-org/gitlab-shell!538</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve logging for non-git commands

See merge request gitlab-org/gitlab-shell!538</pre>
</div>
</content>
</entry>
<entry>
<title>Improve logging for non-git commands</title>
<updated>2021-10-13T14:28:31+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-13T14:22:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=34fa7eb3499c0f85c8610f89c120c1b3c56c1462'/>
<id>34fa7eb3499c0f85c8610f89c120c1b3c56c1462</id>
<content type='text'>
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.

Changelog: added
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.

Changelog: added
</pre>
</div>
</content>
</entry>
<entry>
<title>Reject non-proxied connections when proxy protocol is enabled</title>
<updated>2021-10-12T11:12:34+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-12T11:12:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=22e0350f75fed9f79bac1f68cc5d8a55d6591b84'/>
<id>22e0350f75fed9f79bac1f68cc5d8a55d6591b84</id>
<content type='text'>
This will help to prevent misconfigurations.

Changelog: fixed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will help to prevent misconfigurations.

Changelog: fixed
</pre>
</div>
</content>
</entry>
<entry>
<title>Log command invocation</title>
<updated>2021-10-07T09:43:27+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-07T09:43:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=e77f0d0603d622d3a2554e55fe62bc1615fca55b'/>
<id>e77f0d0603d622d3a2554e55fe62bc1615fca55b</id>
<content type='text'>
Use reflection to log the command we are about to execute, both in
gitlab-shell and gitlab-sshd. Include the environment, which has all
the context we need to understand what the command is expected to do.

Changelog: added
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use reflection to log the command we are about to execute, both in
gitlab-shell and gitlab-sshd. Include the environment, which has all
the context we need to understand what the command is expected to do.

Changelog: added
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix logging channel type</title>
<updated>2021-10-06T12:03:27+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-06T12:03:27+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=b33de0edb56f99f0fdcb7e10ab2a1fa0ef1e4d69'/>
<id>b33de0edb56f99f0fdcb7e10ab2a1fa0ef1e4d69</id>
<content type='text'>
Currently we get this in some log messages:

logrus_error="can not add field \"channel_type\""

This is because we're trying to add a function, rather than the result
of the function call (a string) to the `log.Fields`. Whoops!

Changelog: fixed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Currently we get this in some log messages:

logrus_error="can not add field \"channel_type\""

This is because we're trying to add a function, rather than the result
of the function call (a string) to the `log.Fields`. Whoops!

Changelog: fixed
</pre>
</div>
</content>
</entry>
<entry>
<title>Resolve an error-swallowing issue</title>
<updated>2021-09-30T11:35:48+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-09-30T11:20:06+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=f94f640ec40deddd1f57049d3e4c25a12adaf367'/>
<id>f94f640ec40deddd1f57049d3e4c25a12adaf367</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
