delta/gitlab/gitlab-shell.git/internal/handler, branch master

Include key ID and type in metadata

2020-11-19T23:59:19+00:00

use testhelper for SSH_CONNECTION

2020-11-19T13:32:14+00:00

test for client identity propagation

2020-11-19T13:30:30+00:00

Propagate client identity to gitaly

2020-11-17T14:22:51+00:00

tests: Replace assert with require

2020-10-15T06:44:05+00:00

Testify features sub packages `assert` and `require`. The difference is
subtle, and lost on novice Golang developers that don't read the docs.
To create a more consistent code base `assert` will no longer be used.

This change was generated by a running a sed command on all `_test.go`
files, followed by `goimports -w`.

Generate and log correlation IDs

2020-07-31T12:58:42+00:00

This will make it easier to tie an SSH access request to Rails API and
Gitaly requests.

Log SSH key details

2020-07-23T06:19:57+00:00

Right now when a client such as gitlab-shell calls the
`/api/v4/internal/allowed` API, the response only tells the client what
user has been granted access, and it's impossible to tell which deploy
key/token was used in the authentication request.

This commit adds logs for the following when available:

1. `gl_key_type` (e.g. `deploy_key` or `key`)
2. `gl_key_id`

These fields make it possible for admins to identify the exact record
that was used to authenticate the user.

API changes in the `/internal/allowed` endpoint in
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37289 are needed
to support this.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/203

Log remote IP for executed commands

2020-07-20T20:15:49+00:00

Admins may want to know what client IP originated the request. This
commit adds a `remote_ip` field to the log that extracts the IP address
from the `SSH_CONNECTION` environment variable.

Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/199

Set client name when making requests to Gitaly

2020-05-22T05:35:56+00:00

Remove unnecessary command argument

2020-04-08T01:32:05+00:00