delta/gitlab/gitlab-shell.git/client/httpclient.go, branch id-context-fields

refactor: move away from ioutil (deprecated)

2021-08-19T15:54:20+00:00

test: move os.stat check before the hcc creation

2021-08-17T17:37:17+00:00

fix: make sure ErrCafileNotFound is returned only when the file doesn't exist

2021-08-11T19:04:48+00:00

fix: validate client cert paths exist on disk before proceeding

2021-08-11T19:02:04+00:00

Fix formatting via make fmt

2021-07-26T23:22:34+00:00

Switch to labkit/log for logging functionality

2021-07-22T15:38:47+00:00

Add tracing instrumentation to http client

2021-07-20T15:12:26+00:00

Update httpclient.go with TLS 1.2 as minimum version

2020-11-17T16:27:14+00:00

GitLab API Client support for client certificates

2020-11-17T04:01:50+00:00

Fix gitlab-shell not handling relative URLs over UNIX sockets

2020-08-20T23:54:36+00:00

From
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/4498#note_397401883,
if you specify a relative path such as:

```
external_url 'http://gitlab.example.com/gitlab'
```

gitlab-shell doesn't have a way to pass the `/gitlab` to the host. For example, let's say we have:

```
gitlab_url: "http+unix://%2Fvar%2Fopt%2Fgitlab%2Fgitlab-workhorse%2Fsocket"
```

If we have `/gitlab` as the relative path, how do we specify what is the
UNIX socket path and what is the relative path? If we specify:

```
gitlab_url: "http+unix:///var/opt/gitlab/gitlab-workhorse.socket/gitlab
```

This is ambiguous. Is the socket in
`/var/opt/gitlab/gitlab-workhorse.socket/gitlab` or in
`/var/opt/gitlab/gitlab-workhorse.socket`?

To fix this, this merge request adds an optional
`gitlab_relative_url_root` config parameter:

```
gitlab_url: "http+unix://%2Fvar%2Fopt%2Fgitlab%2Fgitlab-workhorse%2Fsocket"
gitlab_relative_url_root: /gitlab
```

This is only used with UNIX domain sockets to disambiguate the socket
and base URL path. If `gitlab_url` uses `http://` or `https://`, then
`gitlab_relative_url_root` is ignored.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/476