<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git/Makefile, branch main</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Make the boringcrypto check POSIX shell compliant</title>
<updated>2023-04-13T21:46:43+00:00</updated>
<author>
<name>DJ Mountney</name>
<email>dj@gitlab.com</email>
</author>
<published>2023-04-13T21:46:43+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=f8e7110039c2c9d1f7852d7e12797909806fb577'/>
<id>f8e7110039c2c9d1f7852d7e12797909806fb577</id>
<content type='text'>
- Otherwise this fails on some of the omnibus builder images
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
- Otherwise this fails on some of the omnibus builder images
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'brodock/fix-heimdal-homebrew' into 'main'</title>
<updated>2023-04-11T02:11:54+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2023-04-11T02:11:54+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=124ebdd255e6a391639e5f579de5c7d65be88b50'/>
<id>124ebdd255e6a391639e5f579de5c7d65be88b50</id>
<content type='text'>
Fix CGO_CFLAGS to use output from `brew --prefix`

Closes gitlab-development-kit#1790

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/724

Merged-by: Ash McKenzie &lt;amckenzie@gitlab.com&gt;
Approved-by: Ash McKenzie &lt;amckenzie@gitlab.com&gt;
Approved-by: Alejandro Rodríguez &lt;alejandro@gitlab.com&gt;
Co-authored-by: Gabriel Mazetto &lt;gabriel@gitlab.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix CGO_CFLAGS to use output from `brew --prefix`

Closes gitlab-development-kit#1790

See merge request https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/724

Merged-by: Ash McKenzie &lt;amckenzie@gitlab.com&gt;
Approved-by: Ash McKenzie &lt;amckenzie@gitlab.com&gt;
Approved-by: Alejandro Rodríguez &lt;alejandro@gitlab.com&gt;
Co-authored-by: Gabriel Mazetto &lt;gabriel@gitlab.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>Fix CGO_CFLAGS to use output from `brew --prefix`</title>
<updated>2023-04-07T02:20:24+00:00</updated>
<author>
<name>Gabriel Mazetto</name>
<email>gabriel@gitlab.com</email>
</author>
<published>2023-04-07T02:20:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=80dce68581308fe72c0c02a8ff08e3d7131b5aa3'/>
<id>80dce68581308fe72c0c02a8ff08e3d7131b5aa3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Prepare for Go 1.19 FIPS support</title>
<updated>2023-03-07T05:18:11+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2023-03-03T06:48:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=4f5f99875860fcc591a48647a8d5f2b15fb96c60'/>
<id>4f5f99875860fcc591a48647a8d5f2b15fb96c60</id>
<content type='text'>
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/718 will
make Go 1.19 the default for gitlab-shell. Per
https://github.com/golang/go/issues/51940, the dev.boringcrypto branch
no longer exists, and to support FIPS we need to pass along
`GOEXPERIMENT=boringcrypto`.

To do this, we just see if this `GOEXPERIMENT` is available with `go
version` rather than do some more complicated version-specific
comparison.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/718 will
make Go 1.19 the default for gitlab-shell. Per
https://github.com/golang/go/issues/51940, the dev.boringcrypto branch
no longer exists, and to support FIPS we need to pass along
`GOEXPERIMENT=boringcrypto`.

To do this, we just see if this `GOEXPERIMENT` is available with `go
version` rather than do some more complicated version-specific
comparison.
</pre>
</div>
</content>
</entry>
<entry>
<title>Simplify build rule</title>
<updated>2023-02-08T06:08:49+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2023-02-08T06:08:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=c7c52ac4db7fd21d613b7d359649ef4a58f63718'/>
<id>c7c52ac4db7fd21d613b7d359649ef4a58f63718</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add bin/gitlab-sshd as an explicit Makefile target</title>
<updated>2023-02-08T05:15:15+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2023-02-05T00:39:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=435def366122ffc39686f68052d3ed83b19055d3'/>
<id>435def366122ffc39686f68052d3ed83b19055d3</id>
<content type='text'>
Since https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/682,
Kerberos headers and libraries are needed to build gitlab-sshd.  If
they are not available, `make build` successfully compiles
`bin/gitlab-shell` but fails to build `bin/gitlab-sshd`. However,
running `make build` again would do nothing and appear to be succeed
because `bin/gitlab-shell` existed. This led to Omnibus GitLab quietly
dropping the `gitlab-sshd` binary, as seen in
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6446#note_1265879416.

To ensure `make build` properly fails if `bin/gitlab-sshd` cannot
be built, we make the binary an explicit build target.

Changelog: changed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/682,
Kerberos headers and libraries are needed to build gitlab-sshd.  If
they are not available, `make build` successfully compiles
`bin/gitlab-shell` but fails to build `bin/gitlab-sshd`. However,
running `make build` again would do nothing and appear to be succeed
because `bin/gitlab-shell` existed. This led to Omnibus GitLab quietly
dropping the `gitlab-sshd` binary, as seen in
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6446#note_1265879416.

To ensure `make build` properly fails if `bin/gitlab-sshd` cannot
be built, we make the binary an explicit build target.

Changelog: changed
</pre>
</div>
</content>
</entry>
<entry>
<title>Specify CGO_CFLAGS in Makefile to compile gssapi lib</title>
<updated>2023-01-27T16:42:59+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2023-01-27T09:40:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=892a770265bb9f4ecd8aed870228d238099a0afc'/>
<id>892a770265bb9f4ecd8aed870228d238099a0afc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix make install copying the wrong binaries</title>
<updated>2022-06-23T16:28:26+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2022-06-23T16:28:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=ae2081fcae5ce200dc11d934c22a6056de5e4b06'/>
<id>ae2081fcae5ce200dc11d934c22a6056de5e4b06</id>
<content type='text'>
While testing
https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1062, we
found `make install` was not copying the right binaries, such as
`gitlab-shell-authorized-keys-check`.

This might have originally been written with a single binary in mind
(https://gitlab.com/gitlab-org/gitlab-shell/-/issues/207).

Changelog: fixed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
While testing
https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1062, we
found `make install` was not copying the right binaries, such as
`gitlab-shell-authorized-keys-check`.

This might have originally been written with a single binary in mind
(https://gitlab.com/gitlab-org/gitlab-shell/-/issues/207).

Changelog: fixed
</pre>
</div>
</content>
</entry>
<entry>
<title>Use labkit for FIPS check</title>
<updated>2022-05-05T15:40:30+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2022-04-27T09:01:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=a139de096400f6054f76fd7c9466407ee2e7fc53'/>
<id>a139de096400f6054f76fd7c9466407ee2e7fc53</id>
<content type='text'>
New version of LabKit provides FIPS checks that we can use instead
of the custom code
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
New version of LabKit provides FIPS checks that we can use instead
of the custom code
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for FIPS encryption</title>
<updated>2022-04-18T19:16:22+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2022-04-18T19:11:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=3a17a8de7656d18b9f110f7657b6b86bc4dcafe6'/>
<id>3a17a8de7656d18b9f110f7657b6b86bc4dcafe6</id>
<content type='text'>
This commit adds support of using a FIPS-validated SSL library with
compiled Go executables when `FIPS_MODE=1 make` is run. A Go compiler
that supports BoringSSL either directly (e.g. the `dev.boringcrypto`
branch) or with a dynamically linked OpenSSL
(e.g. https://github.com/golang-fips/go) is required.

This is similar to the changes to support FIPS in GitLab Runner and in
GitLab Pages:
https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/716

Changelog: added
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This commit adds support of using a FIPS-validated SSL library with
compiled Go executables when `FIPS_MODE=1 make` is run. A Go compiler
that supports BoringSSL either directly (e.g. the `dev.boringcrypto`
branch) or with a dynamically linked OpenSSL
(e.g. https://github.com/golang-fips/go) is required.

This is similar to the changes to support FIPS in GitLab Runner and in
GitLab Pages:
https://gitlab.com/gitlab-org/gitlab-pages/-/merge_requests/716

Changelog: added
</pre>
</div>
</content>
</entry>
</feed>
