<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git/Makefile, branch 499-log-command-invocation</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>makefile: properly quote '$' in VERSION_STRING</title>
<updated>2021-09-16T17:37:26+00:00</updated>
<author>
<name>Kevin</name>
<email>gitlab@a.ikke.info</email>
</author>
<published>2021-09-16T17:37:26+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=726945b3921144b77b0ddaf2e34e28e2c34b04de'/>
<id>726945b3921144b77b0ddaf2e34e28e2c34b04de</id>
<content type='text'>
If git is not available or gitlab-shell is not built in a repository, it falls back the VERSION file. That command is not properly escaped and results in the message:

&gt; awk: cmd. line:1: Unexpected token

When you remove the `2&gt;/dev/null`. Escape the '$' characters to solve this.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If git is not available or gitlab-shell is not built in a repository, it falls back the VERSION file. That command is not properly escaped and results in the message:

&gt; awk: cmd. line:1: Unexpected token

When you remove the `2&gt;/dev/null`. Escape the '$' characters to solve this.</pre>
</div>
</content>
</entry>
<entry>
<title>build: move build task to the top of the Makefile</title>
<updated>2021-09-07T13:08:05+00:00</updated>
<author>
<name>feistel</name>
<email>6742251-feistel@users.noreply.gitlab.com</email>
</author>
<published>2021-09-07T13:08:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=455ec65dd0272b6975ca1681ba12767b900cf5e4'/>
<id>455ec65dd0272b6975ca1681ba12767b900cf5e4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Make gofmt check fail if there are any matching files</title>
<updated>2021-07-26T23:21:10+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2021-07-26T23:21:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=0997266fc03b0851e4ef52d25dbe8b44bdba7de7'/>
<id>0997266fc03b0851e4ef52d25dbe8b44bdba7de7</id>
<content type='text'>
gofmt doesn't return an exit code 1 if there are matching files:
https://github.com/golang/go/issues/24230

To fix this, use the same trick we use in Workhorse to parse output.
Also add a `make fmt` step to format all the code properly.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
gofmt doesn't return an exit code 1 if there are matching files:
https://github.com/golang/go/issues/24230

To fix this, use the same trick we use in Workhorse to parse output.
Also add a `make fmt` step to format all the code properly.
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a make install command</title>
<updated>2021-07-01T12:47:38+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-07-01T12:26:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=c289756d4ee4cb11fc41dc5ac7aafe19bfc12b92'/>
<id>c289756d4ee4cb11fc41dc5ac7aafe19bfc12b92</id>
<content type='text'>
Changelog: added
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Changelog: added
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix opentracing setup for gitlab-sshd</title>
<updated>2021-05-17T14:52:55+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-05-14T15:47:16+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=de13980f3795679958a65881a813723da37894f5'/>
<id>de13980f3795679958a65881a813723da37894f5</id>
<content type='text'>
Previously, opentracing (if configured) was initialized late in the
gitlab-shell process's lifespan, coming just before making a gRPC
call to Gitaly.

By moving the opentracing initialization to be at process startup, we
make it available for the whole process lifecycle, which is very useful
to gitlab-sshd, as it means we'll only call tracing.Initialize() once
on process startup, rather than once per SSH connection.

To get this working, we need to introduce a context to gitlab-sshd.
This carries the client/service name, but also carries an initial
correlation ID. The main outcome of this is that all calls to the
authorized_keys endpoint from a given gitlab-sshd process will now
share a correlation ID. I don't have a strong opinion about this either
way.

Changelog: fixed
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Previously, opentracing (if configured) was initialized late in the
gitlab-shell process's lifespan, coming just before making a gRPC
call to Gitaly.

By moving the opentracing initialization to be at process startup, we
make it available for the whole process lifecycle, which is very useful
to gitlab-sshd, as it means we'll only call tracing.Initialize() once
on process startup, rather than once per SSH connection.

To get this working, we need to introduce a context to gitlab-sshd.
This carries the client/service name, but also carries an initial
correlation ID. The main outcome of this is that all calls to the
authorized_keys endpoint from a given gitlab-sshd process will now
share a correlation ID. I don't have a strong opinion about this either
way.

Changelog: fixed
</pre>
</div>
</content>
</entry>
<entry>
<title>gitlab-sshd: Support the PROXY protocol</title>
<updated>2021-04-12T17:09:22+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-04-09T11:09:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=db4a3558ed7d484c2a45e6f5857e0a1bc36d3810'/>
<id>db4a3558ed7d484c2a45e6f5857e0a1bc36d3810</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove rubocop from Ruby test</title>
<updated>2020-11-05T13:33:58+00:00</updated>
<author>
<name>Takuya Noguchi</name>
<email>takninnovationresearch@gmail.com</email>
</author>
<published>2020-11-05T13:27:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=a85a32afd9788229d9f33dcbc13fc638e67fc549'/>
<id>a85a32afd9788229d9f33dcbc13fc638e67fc549</id>
<content type='text'>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Apply 1 suggestion(s) to 1 file(s)</title>
<updated>2020-10-16T06:06:42+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-10-16T06:06:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=89a23f1923aa122734e92ddb588f20694959afbf'/>
<id>89a23f1923aa122734e92ddb588f20694959afbf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add support for -version argument</title>
<updated>2020-10-16T05:41:48+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-10-16T03:02:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=9010cdccde441d37aff8a1d76f2e701134e42801'/>
<id>9010cdccde441d37aff8a1d76f2e701134e42801</id>
<content type='text'>
This will help determine the version of the binary particularly on Cloud
Native GitLab, where VERSION may not be shipped with the binaries.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This will help determine the version of the binary particularly on Cloud
Native GitLab, where VERSION may not be shipped with the binaries.
</pre>
</div>
</content>
</entry>
<entry>
<title>Extract coverage for Go code on CI pipeline</title>
<updated>2020-06-06T14:18:35+00:00</updated>
<author>
<name>Takuya Noguchi</name>
<email>takninnovationresearch@gmail.com</email>
</author>
<published>2020-06-04T16:25:45+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=7703f3507623172726df1a41254d70b182e3fcd3'/>
<id>7703f3507623172726df1a41254d70b182e3fcd3</id>
<content type='text'>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Takuya Noguchi &lt;takninnovationresearch@gmail.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
