<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch zj-remove-testify-assert</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>tests: Replace assert with require</title>
<updated>2020-10-15T06:44:05+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2020-10-15T06:44:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=308948b3838c88621e738762241e8d1980881a17'/>
<id>308948b3838c88621e738762241e8d1980881a17</id>
<content type='text'>
Testify features sub packages `assert` and `require`. The difference is
subtle, and lost on novice Golang developers that don't read the docs.
To create a more consistent code base `assert` will no longer be used.

This change was generated by a running a sed command on all `_test.go`
files, followed by `goimports -w`.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Testify features sub packages `assert` and `require`. The difference is
subtle, and lost on novice Golang developers that don't read the docs.
To create a more consistent code base `assert` will no longer be used.

This change was generated by a running a sed command on all `_test.go`
files, followed by `goimports -w`.
</pre>
</div>
</content>
</entry>
<entry>
<title>client: Allow User-Agent header to be overridden</title>
<updated>2020-10-14T15:12:43+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2020-10-14T14:56:49+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=3f03127314bd768efd0bef57915320545afcdd78'/>
<id>3f03127314bd768efd0bef57915320545afcdd78</id>
<content type='text'>
The user agent for requests to the internal API endpoints used the
default Go provided user agent. This change updates that to always set
something else, by default `GitLab-Shell`.

Than for others importing the package, there's a new API to set it to
something else. This has been done with new method, a setter, to
maintain backwards compatibility in the API.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The user agent for requests to the internal API endpoints used the
default Go provided user agent. This change updates that to always set
something else, by default `GitLab-Shell`.

Than for others importing the package, there's a new API to set it to
something else. This has been done with new method, a setter, to
maintain backwards compatibility in the API.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-suppress-random-correlation-id-log' into 'master'</title>
<updated>2020-10-13T23:16:14+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2020-10-13T23:16:14+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=d5fdca30a0e5e7bec6f229aaff966a92ba369331'/>
<id>d5fdca30a0e5e7bec6f229aaff966a92ba369331</id>
<content type='text'>
Drop "generated random correlation ID" log message

See merge request gitlab-org/gitlab-shell!417</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Drop "generated random correlation ID" log message

See merge request gitlab-org/gitlab-shell!417</pre>
</div>
</content>
</entry>
<entry>
<title>Drop "generated random correlation ID" log message</title>
<updated>2020-10-13T21:17:46+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-10-13T21:15:46+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=9fe764b25e1e860fbabbe4d89326b78e622243a9'/>
<id>9fe764b25e1e860fbabbe4d89326b78e622243a9</id>
<content type='text'>
This message happens all the time and doesn't add a lot of value.

Relates to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1275
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This message happens all the time and doesn't add a lot of value.

Relates to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1275
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'release-13.8.0' into 'master'</title>
<updated>2020-10-02T08:16:18+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2020-10-02T08:16:18+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=b0cc0364c7fd23f5c69e8d59c432d096d19ec4c8'/>
<id>b0cc0364c7fd23f5c69e8d59c432d096d19ec4c8</id>
<content type='text'>
Release v13.8.0

See merge request gitlab-org/gitlab-shell!416</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Release v13.8.0

See merge request gitlab-org/gitlab-shell!416</pre>
</div>
</content>
</entry>
<entry>
<title>Release v13.8.0</title>
<updated>2020-10-02T08:03:48+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-10-02T08:03:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=46e242359c45d9501cd6c8af047a927d1be5f23e'/>
<id>46e242359c45d9501cd6c8af047a927d1be5f23e</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-update-gitaly-dep' into 'master'</title>
<updated>2020-10-01T17:04:01+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-10-01T17:04:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=fa036c26d92709c67d92768faee48e0a9625b80d'/>
<id>fa036c26d92709c67d92768faee48e0a9625b80d</id>
<content type='text'>
Update Gitaly module dependency

See merge request gitlab-org/gitlab-shell!414</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update Gitaly module dependency

See merge request gitlab-org/gitlab-shell!414</pre>
</div>
</content>
</entry>
<entry>
<title>Update Gitaly module dependency</title>
<updated>2020-10-01T14:12:24+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2020-10-01T06:58:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=2743dfba8b9e4727ee6df79caf427852b005cf99'/>
<id>2743dfba8b9e4727ee6df79caf427852b005cf99</id>
<content type='text'>
This updates Gitaly's latest Protocol Buffer definitions, which were
last updated in Feburary 2020, with the latest version of Gitaly. This
is done to ensure the definitions are in sync with Workhorse
(https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/619)
and Gitaly.

Because we started tagging Gitaly versions `v13.x.x` instead of
`v1.x.x`, `go get` refuses to update the Gitaly module using the latest
tag or SHA (https://gitlab.com/gitlab-org/gitaly/-/issues/3177).  Go
tries to enforce semantic compatibility by requiring the use of module
paths (e.g. `m/v13`), and Gitaly doesn't adhere to this scheme.

To workaround this issue, we use the replace directive
(https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive):

```
go mod edit -replace gitlab.com/gitlab-org/gitaly=gitlab.com/gitlab-org/gitaly@3f5e218def93024f3aafe590c22cd1b29f744105
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This updates Gitaly's latest Protocol Buffer definitions, which were
last updated in Feburary 2020, with the latest version of Gitaly. This
is done to ensure the definitions are in sync with Workhorse
(https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/619)
and Gitaly.

Because we started tagging Gitaly versions `v13.x.x` instead of
`v1.x.x`, `go get` refuses to update the Gitaly module using the latest
tag or SHA (https://gitlab.com/gitlab-org/gitaly/-/issues/3177).  Go
tries to enforce semantic compatibility by requiring the use of module
paths (e.g. `m/v13`), and Gitaly doesn't adhere to this scheme.

To workaround this issue, we use the replace directive
(https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive):

```
go mod edit -replace gitlab.com/gitlab-org/gitaly=gitlab.com/gitlab-org/gitaly@3f5e218def93024f3aafe590c22cd1b29f744105
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'zj-config-secret' into 'master'</title>
<updated>2020-10-01T09:45:40+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2020-10-01T09:45:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=b7496bb8cdfda7692e447b46a4eaf967ba13b748'/>
<id>b7496bb8cdfda7692e447b46a4eaf967ba13b748</id>
<content type='text'>
config: Set a secret example

See merge request gitlab-org/gitlab-shell!415</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
config: Set a secret example

See merge request gitlab-org/gitlab-shell!415</pre>
</div>
</content>
</entry>
<entry>
<title>config: Set a secret example</title>
<updated>2020-10-01T09:45:40+00:00</updated>
<author>
<name>Zeger-Jan van de Weg</name>
<email>git@zjvandeweg.nl</email>
</author>
<published>2020-10-01T09:45:40+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=6cef08511b8c830fcb67879118e4be8747f07cc6'/>
<id>6cef08511b8c830fcb67879118e4be8747f07cc6</id>
<content type='text'>
The config.yml.example didn't include a field I was expecting to be
there, which lead me to believe the field didn't exist. This change adds
the `secret` YAML field, and describes how it interacts with the
secrets_file.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The config.yml.example didn't include a field I was expecting to be
there, which lead me to believe the field didn't exist. This change adds
the `secret` YAML field, and describes how it interacts with the
secrets_file.
</pre>
</div>
</content>
</entry>
</feed>
