<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch ashmckenzie/13-22-release</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Release v13.22.0</title>
<updated>2021-11-12T04:41:13+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2021-11-12T03:55:09+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=fabc37383230d3e7f579032472c4941d2204faa1'/>
<id>fabc37383230d3e7f579032472c4941d2204faa1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-improve-key-matching-sshd' into 'main'</title>
<updated>2021-11-12T02:09:36+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2021-11-12T02:09:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=0ff9b71545e64766a47b1297a4525ab22552e3e4'/>
<id>0ff9b71545e64766a47b1297a4525ab22552e3e4</id>
<content type='text'>
Relax key and username matching for sshd

See merge request gitlab-org/gitlab-shell!540</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Relax key and username matching for sshd

See merge request gitlab-org/gitlab-shell!540</pre>
</div>
</content>
</entry>
<entry>
<title>Relax key and username matching for sshd</title>
<updated>2021-11-11T00:48:26+00:00</updated>
<author>
<name>Stan Hu</name>
<email>stanhu@gmail.com</email>
</author>
<published>2021-11-10T20:31:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=672013e702cb44c3bc1b46807703295448dc0afc'/>
<id>672013e702cb44c3bc1b46807703295448dc0afc</id>
<content type='text'>
Due to the way sshd works, gitlab-shell could be called with a single
string in the form:

```
/path/to/gitlab-shell -c key-id
```

However, due to the tightening of the regular expressions in fcff692b
this string no longer matches, so logins would fail with:

```
Failed to get username: who='' is invalid
```

This can be reproduced by changing the user's shell to point to
gitlab-shell. For example:

```
usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
```

While setting gitlab-shell as the user's shell isn't officially
supported, gitlab-shell still should be able to cope with the key being
specified as the last argument. We now split the argument list and use
the last value.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Due to the way sshd works, gitlab-shell could be called with a single
string in the form:

```
/path/to/gitlab-shell -c key-id
```

However, due to the tightening of the regular expressions in fcff692b
this string no longer matches, so logins would fail with:

```
Failed to get username: who='' is invalid
```

This can be reproduced by changing the user's shell to point to
gitlab-shell. For example:

```
usermod git -s /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell
```

While setting gitlab-shell as the user's shell isn't officially
supported, gitlab-shell still should be able to cope with the key being
specified as the last argument. We now split the argument list and use
the last value.

Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/530
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'id-logging-for-handler' into 'main'</title>
<updated>2021-10-21T03:50:11+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2021-10-21T03:50:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=5cccb38df60b9ecef744e8bf1cbdff68066e9d5e'/>
<id>5cccb38df60b9ecef744e8bf1cbdff68066e9d5e</id>
<content type='text'>
Add logging to handler/exec.go and config/config.go

See merge request gitlab-org/gitlab-shell!539</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add logging to handler/exec.go and config/config.go

See merge request gitlab-org/gitlab-shell!539</pre>
</div>
</content>
</entry>
<entry>
<title>Add logging to RunGitalyCommand func</title>
<updated>2021-10-20T09:02:09+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-10-20T08:34:10+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=1dede51df96e9524b5519e115db5a0e1c719d03b'/>
<id>1dede51df96e9524b5519e115db5a0e1c719d03b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Log SSL_CERT_DIR when it's configured</title>
<updated>2021-10-20T09:02:09+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-10-20T08:33:48+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=f9f5423cf8d65c97d42991e218b990e5132fe293'/>
<id>f9f5423cf8d65c97d42991e218b990e5132fe293</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '499-log-non-git-commands' into 'main'</title>
<updated>2021-10-13T23:23:42+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2021-10-13T23:23:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=9dcfcd3a1d3001fb87b6e807f7fed31a05f509b2'/>
<id>9dcfcd3a1d3001fb87b6e807f7fed31a05f509b2</id>
<content type='text'>
Improve logging for non-git commands

See merge request gitlab-org/gitlab-shell!538</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve logging for non-git commands

See merge request gitlab-org/gitlab-shell!538</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '532-proxy-protocol-require' into 'main'</title>
<updated>2021-10-13T14:32:28+00:00</updated>
<author>
<name>Igor Drozdov</name>
<email>idrozdov@gitlab.com</email>
</author>
<published>2021-10-13T14:32:28+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=7cb9be1e9bc1795d92f4f724e2182af019e3d0a8'/>
<id>7cb9be1e9bc1795d92f4f724e2182af019e3d0a8</id>
<content type='text'>
Reject non-proxied connections when proxy protocol is enabled

Closes #532

See merge request gitlab-org/gitlab-shell!536</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reject non-proxied connections when proxy protocol is enabled

Closes #532

See merge request gitlab-org/gitlab-shell!536</pre>
</div>
</content>
</entry>
<entry>
<title>Improve logging for non-git commands</title>
<updated>2021-10-13T14:28:31+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-13T14:22:11+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=34fa7eb3499c0f85c8610f89c120c1b3c56c1462'/>
<id>34fa7eb3499c0f85c8610f89c120c1b3c56c1462</id>
<content type='text'>
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.

Changelog: added
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Several of our commands only touch the internal API, and go nowhere
near Gitaly. Improve logging for each of these in a single MR. In
general, we want to be able to tell what happened in the execution of
each command, and to track failures down to a specific line of code.

Changelog: added
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-update-go-1.16.9' into 'main'</title>
<updated>2021-10-13T11:54:41+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2021-10-13T11:54:41+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=d868b40ae666a11749ee9ec652441221197a2670'/>
<id>d868b40ae666a11749ee9ec652441221197a2670</id>
<content type='text'>
Update to Go v1.16.9

See merge request gitlab-org/gitlab-shell!537</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update to Go v1.16.9

See merge request gitlab-org/gitlab-shell!537</pre>
</div>
</content>
</entry>
</feed>
