<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-shell.git, branch 181-migrate-gitlab-shell-checks-fallback</title>
<subtitle>gitlab.com: gitlab-org/gitlab-shell.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/'/>
<entry>
<title>Add Executable struct</title>
<updated>2019-08-02T08:10:17+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-08-02T08:10:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=3b6f9f7583755e041e76142d7caf7716937907fa'/>
<id>3b6f9f7583755e041e76142d7caf7716937907fa</id>
<content type='text'>
This struct is responsible for determining the name and
root dir of the executable.

The `RootDir` property will be used to find the config.

The `Name` property will be used to determine what `Command`
and `CommandArgs` to be built.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This struct is responsible for determining the name and
root dir of the executable.

The `RootDir` property will be used to find the config.

The `Name` property will be used to determine what `Command`
and `CommandArgs` to be built.
</pre>
</div>
</content>
</entry>
<entry>
<title>Rename CommandArgs to Shell</title>
<updated>2019-07-31T04:03:43+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-07-29T07:59:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=592823d5e25006331b361b36cc61df7802fc1938'/>
<id>592823d5e25006331b361b36cc61df7802fc1938</id>
<content type='text'>
Other functions are still expecting for `CommandArgs` instead
of `Shell`. They should be expecting `commandargs.Shell` now
since it has been renamed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Other functions are still expecting for `CommandArgs` instead
of `Shell`. They should be expecting `commandargs.Shell` now
since it has been renamed.
</pre>
</div>
</content>
</entry>
<entry>
<title>Support different CommandArgs type</title>
<updated>2019-07-31T04:03:37+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-07-29T07:56:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=3b0176df497263323da2fae793a79b568502e6db'/>
<id>3b0176df497263323da2fae793a79b568502e6db</id>
<content type='text'>
`CommandArgs` has been renamed to `Shell`.

An interface has been added that includes `Executable()` and
`Arguments()` method. The `BaseArgs` implement this methods
and should be embeeded in each type.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
`CommandArgs` has been renamed to `Shell`.

An interface has been added that includes `Executable()` and
`Arguments()` method. The `BaseArgs` implement this methods
and should be embeeded in each type.
</pre>
</div>
</content>
</entry>
<entry>
<title>Support falling back to ruby version of checkers</title>
<updated>2019-07-29T06:58:32+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-07-29T06:33:01+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=aab85f3600caf04b491d6ca4fc3f0f004d9e3fc0'/>
<id>aab85f3600caf04b491d6ca4fc3f0f004d9e3fc0</id>
<content type='text'>
Rename the ruby scripts to have `-ruby` suffix and add a symlink
for both to `./gitlab-shell`. The executable name will be used to
determine how args will be parsed.

For now, we only parse the arguments for gitlab-shell commands. If
the executable is `gitlab-shell-authorized-keys-check` or
`gitlab-shell-authorized-principals-check`, it'll always fallback
to the ruby version.

Ruby specs test the ruby script, the fallback from go to ruby and
go implementation of both (still pending).
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Rename the ruby scripts to have `-ruby` suffix and add a symlink
for both to `./gitlab-shell`. The executable name will be used to
determine how args will be parsed.

For now, we only parse the arguments for gitlab-shell commands. If
the executable is `gitlab-shell-authorized-keys-check` or
`gitlab-shell-authorized-principals-check`, it'll always fallback
to the ruby version.

Ruby specs test the ruby script, the fallback from go to ruby and
go implementation of both (still pending).
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'pb-update-rubygems-ci' into 'master'</title>
<updated>2019-07-22T14:06:50+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-07-22T14:06:50+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=ed0460374a5ca13d9ea17c6a9c21151319b7fd53'/>
<id>ed0460374a5ca13d9ea17c6a9c21151319b7fd53</id>
<content type='text'>
Update rubygems version on CI for go tests

See merge request gitlab-org/gitlab-shell!320</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Update rubygems version on CI for go tests

See merge request gitlab-org/gitlab-shell!320</pre>
</div>
</content>
</entry>
<entry>
<title>Update rubygems version on CI for go tests</title>
<updated>2019-07-22T12:41:04+00:00</updated>
<author>
<name>Patrick Bajao</name>
<email>ebajao@gitlab.com</email>
</author>
<published>2019-07-22T11:42:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=021688b721bbf5848516bfe60b6d059814191f6c'/>
<id>021688b721bbf5848516bfe60b6d059814191f6c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '198-update-phony-to-have-accurate-list-of-targets' into 'master'</title>
<updated>2019-07-01T10:25:58+00:00</updated>
<author>
<name>Nick Thomas</name>
<email>nick@gitlab.com</email>
</author>
<published>2019-07-01T10:25:58+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=5b8e04fbc8ff4ca866dea4c97c881db7e8b087bb'/>
<id>5b8e04fbc8ff4ca866dea4c97c881db7e8b087bb</id>
<content type='text'>
Resolve "Update .PHONY to have accurate list of targets"

Closes #198

See merge request gitlab-org/gitlab-shell!316</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Resolve "Update .PHONY to have accurate list of targets"

Closes #198

See merge request gitlab-org/gitlab-shell!316</pre>
</div>
</content>
</entry>
<entry>
<title>Update .PHONY to be accurate</title>
<updated>2019-06-28T02:21:32+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-06-27T14:36:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=1933630419b77e6b046ae72baf0bd96c6c369f24'/>
<id>1933630419b77e6b046ae72baf0bd96c6c369f24</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>New bin/gitlab-shell Makefile target</title>
<updated>2019-06-28T02:21:32+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-06-28T02:20:03+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=eb4cf020efbd7a25763fdf10e886fd495397a240'/>
<id>eb4cf020efbd7a25763fdf10e886fd495397a240</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove errant newline for consistency</title>
<updated>2019-06-27T14:36:42+00:00</updated>
<author>
<name>Ash McKenzie</name>
<email>amckenzie@gitlab.com</email>
</author>
<published>2019-06-27T14:36:42+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/gitlab/gitlab-shell.git/commit/?id=0bc2503a85eea9efdc9bb0d072b1fc832d56d754'/>
<id>0bc2503a85eea9efdc9bb0d072b1fc832d56d754</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
