From aa372a2a5e9b0ac28db91e8c6f5edcba80b487d0 Mon Sep 17 00:00:00 2001 From: Kamil Trzcinski Date: Fri, 10 Jul 2015 11:46:53 +0200 Subject: Disable link to runner if it's not assigned to specific project: fixes 404 when clicking on available runner from project's page --- CHANGELOG | 1 + app/views/runners/_runner.html.haml | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index 6631d52..8cbfefe 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -12,6 +12,7 @@ v7.13.0 - Allow to specify allow_failure for job - Build traces is stored in the file instead of database - Make the builds path configurable + - Disable link to runner if it's not assigned to specific project v7.12.2 - Revert: Runner without tag should pick builds without tag only diff --git a/app/views/runners/_runner.html.haml b/app/views/runners/_runner.html.haml index 1d88d69..02424f5 100644 --- a/app/views/runners/_runner.html.haml +++ b/app/views/runners/_runner.html.haml @@ -2,11 +2,13 @@ %h4 = runner_status_icon(runner) %span.monospace - = link_to runner.short_sha, [@project, runner] - if @runners.include?(runner) + = link_to runner.short_sha, [@project, runner] %small =link_to edit_project_runner_path(@project, runner) do %i.fa.icon-edit.btn + - else + = runner.short_sha .pull-right - if @runners.include?(runner) -- cgit v1.2.1