From b050bb5bada27f38c6308ca33ac081f56cc681a5 Mon Sep 17 00:00:00 2001 From: Robert Speicher Date: Sat, 9 May 2015 15:45:22 -0400 Subject: Fix 2FA backup code removal --- spec/features/login_spec.rb | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'spec') diff --git a/spec/features/login_spec.rb b/spec/features/login_spec.rb index f1e24c54240..ca7fb022a2a 100644 --- a/spec/features/login_spec.rb +++ b/spec/features/login_spec.rb @@ -47,7 +47,7 @@ feature 'Login' do before do expect(codes.size).to eq 5 - # Because `generate_otp_backup_codes!` doesn't actually do this... + # Ensure the generated codes get saved user.save end @@ -58,20 +58,18 @@ feature 'Login' do end it 'invalidates the used code' do - # FIXME (rspeicher): Broken library is broken - expect { enter_code(codes.sample) }.to change { user.otp_backup_codes.size }.by(-1) + expect { enter_code(codes.sample) }. + to change { user.reload.otp_backup_codes.size }.by(-1) end end context 'with invalid code' do it 'blocks login' do - # FIXME (rspeicher): Broken library is broken code = codes.sample expect(user.invalidate_otp_backup_code!(code)).to eq true - expect(user.otp_backup_codes.size).to eq 4 # Passes + user.save! - user.reload - expect(user.otp_backup_codes.size).to eq 4 # Fails... WAT?! + expect(user.reload.otp_backup_codes.size).to eq 4 enter_code(code) expect(page).to have_content('Invalid two-factor code') -- cgit v1.2.1