From 181b9b3e7328070f6846c9547d166ba0128e415c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= Date: Fri, 2 Aug 2019 13:28:59 +0200 Subject: Respect needs for artifacts When `needs:` is defined, the value of it is not respected when returning a list of artifacts to the runner from the job. --- spec/models/ci/build_spec.rb | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) (limited to 'spec/models/ci/build_spec.rb') diff --git a/spec/models/ci/build_spec.rb b/spec/models/ci/build_spec.rb index 8768e914284..0387073cffb 100644 --- a/spec/models/ci/build_spec.rb +++ b/spec/models/ci/build_spec.rb @@ -630,12 +630,17 @@ describe Ci::Build do create(:ci_build, pipeline: pipeline, name: 'final', stage_idx: 3, stage: 'deploy', options: { - dependencies: dependencies, - needs: needs + dependencies: dependencies } ) end + before do + needs.to_a.each do |need| + create(:ci_build_need, build: final, name: need) + end + end + subject { final.dependencies } context 'when depedencies are defined' do @@ -648,6 +653,14 @@ describe Ci::Build do let(:needs) { %w(build rspec staging) } it { is_expected.to contain_exactly(build, rspec_test, staging) } + + context 'when ci_dag_support is disabled' do + before do + stub_feature_flags(ci_dag_support: false) + end + + it { is_expected.to contain_exactly(build, rspec_test, rubocop_test, staging) } + end end context 'when needs and dependencies are defined' do -- cgit v1.2.1