From 76b078ceffc2781fc88e80300c526f130ea87fbe Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Tue, 7 Feb 2017 12:09:26 -0600 Subject: Improve gl.utils.handleLocationHash tests --- .../javascripts/lib/utils/common_utils_spec.js.es6 | 29 +++++++++++++++++++--- 1 file changed, 25 insertions(+), 4 deletions(-) (limited to 'spec/javascripts') diff --git a/spec/javascripts/lib/utils/common_utils_spec.js.es6 b/spec/javascripts/lib/utils/common_utils_spec.js.es6 index ff70664546d..bf3bc622cdc 100644 --- a/spec/javascripts/lib/utils/common_utils_spec.js.es6 +++ b/spec/javascripts/lib/utils/common_utils_spec.js.es6 @@ -43,14 +43,35 @@ require('~/lib/utils/common_utils'); describe('gl.utils.handleLocationHash', () => { beforeEach(() => { - window.history.pushState({}, null, '#definição'); + spyOn(window.document, 'getElementById').and.callThrough(); }); + function expectGetElementIdToHaveBeenCalledWith(elementId) { + expect(window.document.getElementById).toHaveBeenCalledWith(elementId); + } + it('decodes hash parameter', () => { - spyOn(window.document, 'getElementById').and.callThrough(); + window.history.pushState({}, null, '#random-hash'); + gl.utils.handleLocationHash(); + + expectGetElementIdToHaveBeenCalledWith('random-hash'); + expectGetElementIdToHaveBeenCalledWith('user-content-random-hash'); + }); + + it('decodes cyrillic hash parameter', () => { + window.history.pushState({}, null, '#definição'); gl.utils.handleLocationHash(); - expect(window.document.getElementById).toHaveBeenCalledWith('definição'); - expect(window.document.getElementById).toHaveBeenCalledWith('user-content-definição'); + + expectGetElementIdToHaveBeenCalledWith('definição'); + expectGetElementIdToHaveBeenCalledWith('user-content-definição'); + }); + + it('decodes encoded cyrillic hash parameter', () => { + window.history.pushState({}, null, '#defini%C3%A7%C3%A3o'); + gl.utils.handleLocationHash(); + + expectGetElementIdToHaveBeenCalledWith('definição'); + expectGetElementIdToHaveBeenCalledWith('user-content-definição'); }); }); -- cgit v1.2.1