From bee837d7b5025a2e170dc0c857b188b4d89c014f Mon Sep 17 00:00:00 2001 From: James Lopez Date: Thu, 15 Feb 2018 08:53:09 +0100 Subject: some initial refactoring --- spec/helpers/blob_helper_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'spec/helpers/blob_helper_spec.rb') diff --git a/spec/helpers/blob_helper_spec.rb b/spec/helpers/blob_helper_spec.rb index a030796c54e..d1968eac3e3 100644 --- a/spec/helpers/blob_helper_spec.rb +++ b/spec/helpers/blob_helper_spec.rb @@ -74,7 +74,7 @@ describe BlobHelper do end end - describe "#edit_blob_link" do + describe "#edit_blob_element" do let(:namespace) { create(:namespace, name: 'gitlab' )} let(:project) { create(:project, :repository, namespace: namespace) } @@ -86,7 +86,7 @@ describe BlobHelper do it 'verifies blob is text' do expect(helper).not_to receive(:blob_text_viewable?) - button = edit_blob_link(project, 'refs/heads/master', 'README.md') + button = edit_blob_element(project, 'refs/heads/master', 'README.md') expect(button).to start_with(' Date: Thu, 22 Feb 2018 13:54:19 +0100 Subject: refactor code based on feedback --- spec/helpers/blob_helper_spec.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'spec/helpers/blob_helper_spec.rb') diff --git a/spec/helpers/blob_helper_spec.rb b/spec/helpers/blob_helper_spec.rb index d1968eac3e3..0548e71c89d 100644 --- a/spec/helpers/blob_helper_spec.rb +++ b/spec/helpers/blob_helper_spec.rb @@ -86,7 +86,7 @@ describe BlobHelper do it 'verifies blob is text' do expect(helper).not_to receive(:blob_text_viewable?) - button = edit_blob_element(project, 'refs/heads/master', 'README.md') + button = edit_blob_button(project, 'refs/heads/master', 'README.md') expect(button).to start_with(' Date: Fri, 23 Feb 2018 16:52:18 +0100 Subject: refactor methods inline --- spec/helpers/blob_helper_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'spec/helpers/blob_helper_spec.rb') diff --git a/spec/helpers/blob_helper_spec.rb b/spec/helpers/blob_helper_spec.rb index 0548e71c89d..1fa194fe1b8 100644 --- a/spec/helpers/blob_helper_spec.rb +++ b/spec/helpers/blob_helper_spec.rb @@ -74,7 +74,7 @@ describe BlobHelper do end end - describe "#edit_blob_element" do + describe "#edit_blob_link" do let(:namespace) { create(:namespace, name: 'gitlab' )} let(:project) { create(:project, :repository, namespace: namespace) } -- cgit v1.2.1