From 62d7990b9bb30cf33ed87017c5c633d1cccc75c2 Mon Sep 17 00:00:00 2001 From: Toon Claes Date: Thu, 28 Feb 2019 19:57:34 +0100 Subject: Ran standardrb --fix on the whole codebase Inspired by https://twitter.com/searls/status/1101137953743613952 I decided to try https://github.com/testdouble/standard on our codebase. It's opinionated, but at least it's a _standard_. --- spec/finders/snippets_finder_spec.rb | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'spec/finders/snippets_finder_spec.rb') diff --git a/spec/finders/snippets_finder_spec.rb b/spec/finders/snippets_finder_spec.rb index 134fb5f2c04..1d978b5aebf 100644 --- a/spec/finders/snippets_finder_spec.rb +++ b/spec/finders/snippets_finder_spec.rb @@ -1,11 +1,11 @@ -require 'spec_helper' +require "spec_helper" describe SnippetsFinder do include Gitlab::Allowable using RSpec::Parameterized::TableSyntax - describe '#initialize' do - it 'raises ArgumentError when a project and author are given' do + describe "#initialize" do + it "raises ArgumentError when a project and author are given" do user = build(:user) project = build(:project) @@ -14,7 +14,7 @@ describe SnippetsFinder do end end - context 'filter by scope' do + context "filter by scope" do let(:user) { create :user } let!(:snippet1) { create(:personal_snippet, :private, author: user) } let!(:snippet2) { create(:personal_snippet, :internal, author: user) } @@ -48,7 +48,7 @@ describe SnippetsFinder do end end - context 'filter by author' do + context "filter by author" do let(:user) { create :user } let(:user1) { create :user } let!(:snippet1) { create(:personal_snippet, :private, author: user) } @@ -96,7 +96,7 @@ describe SnippetsFinder do expect(snippets).not_to include(snippet2, snippet1) end - it 'returns all snippets for an admin' do + it "returns all snippets for an admin" do admin = create(:user, :admin) snippets = described_class.new(admin, author: user).execute @@ -104,7 +104,7 @@ describe SnippetsFinder do end end - context 'filter by project' do + context "filter by project" do let(:user) { create :user } let(:group) { create :group, :public } let(:project1) { create(:project, :public, group: group) } @@ -165,7 +165,7 @@ describe SnippetsFinder do expect(snippets).to include(@snippet1) end - it 'returns all snippets for an admin' do + it "returns all snippets for an admin" do admin = create(:user, :admin) snippets = described_class.new(admin, project: project1).execute @@ -173,28 +173,28 @@ describe SnippetsFinder do end end - describe '#execute' do + describe "#execute" do let(:project) { create(:project, :public) } let!(:project_snippet) { create(:project_snippet, :public, project: project) } let!(:personal_snippet) { create(:personal_snippet, :public) } let(:user) { create(:user) } subject(:finder) { described_class.new(user) } - it 'returns project- and personal snippets' do + it "returns project- and personal snippets" do expect(finder.execute).to contain_exactly(project_snippet, personal_snippet) end - context 'when the user cannot read cross project' do + context "when the user cannot read cross project" do before do allow(Ability).to receive(:allowed?).and_call_original allow(Ability).to receive(:allowed?).with(user, :read_cross_project) { false } end - it 'returns only personal snippets when the user cannot read cross project' do + it "returns only personal snippets when the user cannot read cross project" do expect(finder.execute).to contain_exactly(personal_snippet) end end end - it_behaves_like 'snippet visibility' + it_behaves_like "snippet visibility" end -- cgit v1.2.1