From 98087a9853200d21ecaf50c075ee4346769c89c6 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 18 Feb 2021 06:09:43 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- spec/factories_spec.rb | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'spec/factories_spec.rb') diff --git a/spec/factories_spec.rb b/spec/factories_spec.rb index 38ade20de28..cc84a5de368 100644 --- a/spec/factories_spec.rb +++ b/spec/factories_spec.rb @@ -29,9 +29,16 @@ RSpec.describe 'factories' do # and reuse them in other factories. # # However, for some factories we cannot use FactoryDefault because the - # associations must be unique and cannot be reused. + # associations must be unique and cannot be reused, or the factory default + # is being mutated. skip_factory_defaults = %i[ fork_network_member + group_member + import_state + namespace + project_broken_repo + users_star_project + wiki_page ].to_set.freeze # Some factories and their corresponding models are based on @@ -46,9 +53,9 @@ RSpec.describe 'factories' do .partition { |factory| skip_factory_defaults.include?(factory.name) } context 'with factory defaults', factory_default: :keep do - let_it_be(:namespace) { create_default(:namespace) } - let_it_be(:project) { create_default(:project, :repository) } - let_it_be(:user) { create_default(:user) } + let_it_be(:namespace) { create_default(:namespace).freeze } + let_it_be(:project) { create_default(:project, :repository).freeze } + let_it_be(:user) { create_default(:user).freeze } before do factories_based_on_view.each do |factory| -- cgit v1.2.1