From a2ec7de97ad30f669654f335882cda319cc50026 Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Fri, 11 Jan 2019 15:32:54 +0100 Subject: Use the MR IID in the docs Review Apps URLs We're taking advantage of the pipelines for merge requests https://docs.gitlab.com/ee/ci/merge_request_pipelines/. This will result in a nicer URL which will be more informative than the previous one where a string of random characters was used. --- scripts/trigger-build-docs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'scripts/trigger-build-docs') diff --git a/scripts/trigger-build-docs b/scripts/trigger-build-docs index dfc8ee6050a..5c55fd3ee31 100755 --- a/scripts/trigger-build-docs +++ b/scripts/trigger-build-docs @@ -16,14 +16,12 @@ end GITLAB_DOCS_REPO = 'gitlab-com/gitlab-docs'.freeze # -# Truncate the remote docs branch name otherwise we hit the filesystem -# limit and the directory name where NGINX serves the site won't match -# the branch name. +# This is the branch that will be created in the gitlab-docs project. +# Name it after the product we're previewing and the ID of the MR that +# kicked the review app. # def docs_branch - # The maximum string length a file can have on a filesystem (ext4) - # is 63 characters. CI_ENVIRONMENT_SLUG is limited to 24 characters. - ENV["CI_ENVIRONMENT_SLUG"] + "docs-preview-#{slug}-#{ENV["CI_MERGE_REQUEST_IID"]}" end # -- cgit v1.2.1