From 9d06504d4277ecf53e6f19014d060c6e7009dc0d Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Wed, 28 Feb 2018 21:23:58 +0000 Subject: Forbid all inline script tags in Linter::InlineJavaScript --- lib/haml_lint/inline_javascript.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/haml_lint/inline_javascript.rb') diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb index f5485eb89fa..872502bc8e3 100644 --- a/lib/haml_lint/inline_javascript.rb +++ b/lib/haml_lint/inline_javascript.rb @@ -8,7 +8,7 @@ unless Rails.env.production? include LinterRegistry def visit_filter(node) - return unless node.filter_type == 'javascript' + return unless node.tag_name == 'script' record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)') end -- cgit v1.2.1 From 83b3e9fa40571c7475bc803b15e9b57ad2dc36b8 Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Wed, 28 Feb 2018 21:42:34 +0000 Subject: Update inline_javascript.rb --- lib/haml_lint/inline_javascript.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/haml_lint/inline_javascript.rb') diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb index 872502bc8e3..ff447513fd1 100644 --- a/lib/haml_lint/inline_javascript.rb +++ b/lib/haml_lint/inline_javascript.rb @@ -6,8 +6,8 @@ unless Rails.env.production? module HamlLint class Linter::InlineJavaScript < Linter include LinterRegistry - - def visit_filter(node) + + def visit_tag(node) return unless node.tag_name == 'script' record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)') -- cgit v1.2.1 From 25283e71011490c674c54e64384957a692235e38 Mon Sep 17 00:00:00 2001 From: Connor Shea Date: Wed, 28 Feb 2018 15:58:12 -0700 Subject: Update inline_javascript.rb to lint uses of the javascript filter as well as script tags. --- lib/haml_lint/inline_javascript.rb | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'lib/haml_lint/inline_javascript.rb') diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb index ff447513fd1..4f776330e80 100644 --- a/lib/haml_lint/inline_javascript.rb +++ b/lib/haml_lint/inline_javascript.rb @@ -6,7 +6,13 @@ unless Rails.env.production? module HamlLint class Linter::InlineJavaScript < Linter include LinterRegistry - + + def visit_filter(node) + return unless node.filter_type == 'javascript' + + record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)') + end + def visit_tag(node) return unless node.tag_name == 'script' -- cgit v1.2.1