From ff9fd24cf0ba9ec2ffddb203d3a61d9e4982a4f5 Mon Sep 17 00:00:00 2001 From: Felipe Artur Date: Thu, 20 Oct 2016 19:29:14 -0200 Subject: disable markdown in comments when referencing disabled features --- lib/banzai/reference_parser/base_parser.rb | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'lib/banzai/reference_parser/base_parser.rb') diff --git a/lib/banzai/reference_parser/base_parser.rb b/lib/banzai/reference_parser/base_parser.rb index f5d110e987b..c60cf46c141 100644 --- a/lib/banzai/reference_parser/base_parser.rb +++ b/lib/banzai/reference_parser/base_parser.rb @@ -61,6 +61,8 @@ module Banzai project_attr = 'data-project' nodes.select do |node| + next unless can_read_reference?(user) + if node.has_attribute?(project_attr) node_id = node.attr(project_attr).to_i @@ -226,6 +228,15 @@ module Banzai attr_reader :current_user, :project + # When a feature is disabled or visible only for + # team members we should not allow team members + # see reference comments. + # Override this method on classes where feature + # visibility should be checked. + def can_read_reference?(user) + true + end + def lazy(&block) Gitlab::Lazy.new(&block) end -- cgit v1.2.1