From a2b2f1ead7f247e37f8e07feb7e6d1ab9997bc00 Mon Sep 17 00:00:00 2001 From: Fatih Acet Date: Fri, 21 Jul 2017 12:45:09 +0300 Subject: IssueNotesRefactor: Fix issue spinach tests. --- features/project/issues/issues.feature | 1 - 1 file changed, 1 deletion(-) (limited to 'features') diff --git a/features/project/issues/issues.feature b/features/project/issues/issues.feature index 4f905674d8c..abc23257de5 100644 --- a/features/project/issues/issues.feature +++ b/features/project/issues/issues.feature @@ -46,7 +46,6 @@ Feature: Project Issues Given I visit issue page "Release 0.4" And I leave a comment like "XML attached" Then I should see comment "XML attached" - And I should see an error alert section within the comment form @javascript Scenario: Visiting Issues after being sorted the list -- cgit v1.2.1 From 2faf28fe1c03802be69651e98d0c57803629126a Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Thu, 10 Aug 2017 17:27:17 +0100 Subject: Remove forgotten fdescribe --- features/steps/project/issues/issues.rb | 1 + features/steps/shared/note.rb | 2 ++ 2 files changed, 3 insertions(+) (limited to 'features') diff --git a/features/steps/project/issues/issues.rb b/features/steps/project/issues/issues.rb index 2deef9036d3..b9460f5b534 100644 --- a/features/steps/project/issues/issues.rb +++ b/features/steps/project/issues/issues.rb @@ -168,6 +168,7 @@ class Spinach::Features::ProjectIssues < Spinach::FeatureSteps author: project.users.first, description: "# Description header" ) + wait_for_requests end step 'project "Shop" have "Tweet control" open issue' do diff --git a/features/steps/shared/note.rb b/features/steps/shared/note.rb index 80187b83fee..f53919f4135 100644 --- a/features/steps/shared/note.rb +++ b/features/steps/shared/note.rb @@ -163,5 +163,7 @@ module SharedNote page.within(".note") do expect(page).to have_content("+1 Awesome!") end + + wait_for_requests end end -- cgit v1.2.1 From ea448039c8954e5a1d175f827b0205754dfb6dd2 Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Thu, 10 Aug 2017 18:36:39 +0100 Subject: Fix broken tests --- features/steps/shared/note.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'features') diff --git a/features/steps/shared/note.rb b/features/steps/shared/note.rb index f53919f4135..1c3432c3ca1 100644 --- a/features/steps/shared/note.rb +++ b/features/steps/shared/note.rb @@ -137,7 +137,7 @@ module SharedNote step 'The comment with the header should not have an ID' do page.within(".note-body > .note-text") do - expect(page).to have_content("Comment with a header") + expect(page).to have_content("Comment with a header") expect(page).not_to have_css("#comment-with-a-header") end end @@ -153,10 +153,13 @@ module SharedNote note.find('.js-note-edit').click end + page.find('.current-note-edit-form textarea') + page.within(".current-note-edit-form") do - fill_in 'note[note]', with: '+1 Awesome!' + fill_in '#note-body', with: '+1 Awesome!' click_button 'Save comment' end + wait_for_requests end step 'I should see +1 in the description' do -- cgit v1.2.1 From b38e690344a3d37e3be0305c88ea96adbc82aca6 Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Fri, 11 Aug 2017 12:51:41 +0100 Subject: Fix open discussions --- features/project/issues/issues.feature | 1 + 1 file changed, 1 insertion(+) (limited to 'features') diff --git a/features/project/issues/issues.feature b/features/project/issues/issues.feature index abc23257de5..4f905674d8c 100644 --- a/features/project/issues/issues.feature +++ b/features/project/issues/issues.feature @@ -46,6 +46,7 @@ Feature: Project Issues Given I visit issue page "Release 0.4" And I leave a comment like "XML attached" Then I should see comment "XML attached" + And I should see an error alert section within the comment form @javascript Scenario: Visiting Issues after being sorted the list -- cgit v1.2.1 From b96a3d4d60747102bc437c99b4d040c5c0329689 Mon Sep 17 00:00:00 2001 From: Filipa Lacerda Date: Fri, 11 Aug 2017 15:28:46 +0100 Subject: Fix open discussions Put back deleted tests --- features/steps/shared/note.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'features') diff --git a/features/steps/shared/note.rb b/features/steps/shared/note.rb index 1c3432c3ca1..86c2600da6c 100644 --- a/features/steps/shared/note.rb +++ b/features/steps/shared/note.rb @@ -156,7 +156,7 @@ module SharedNote page.find('.current-note-edit-form textarea') page.within(".current-note-edit-form") do - fill_in '#note-body', with: '+1 Awesome!' + fill_in 'note[note]', with: '+1 Awesome!' click_button 'Save comment' end wait_for_requests -- cgit v1.2.1