From 7cefdb49eb460e87e3c3b827af32ae1b6834c4da Mon Sep 17 00:00:00 2001 From: Robert Schilling Date: Tue, 29 Jul 2014 11:49:46 +0200 Subject: Prevent 500 if hook url is down, fixes #7376 --- features/steps/project/hooks.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'features/steps/project/hooks.rb') diff --git a/features/steps/project/hooks.rb b/features/steps/project/hooks.rb index 30da589260d..2bd383676e7 100644 --- a/features/steps/project/hooks.rb +++ b/features/steps/project/hooks.rb @@ -38,6 +38,11 @@ class ProjectHooks < Spinach::FeatureSteps click_link 'Test Hook' end + step 'I click test hook button with invalid URL' do + stub_request(:post, @hook.url).to_raise(SocketError) + click_link 'Test Hook' + end + step 'hook should be triggered' do page.current_path.should == project_hooks_path(current_project) page.should have_selector '.flash-notice', @@ -49,4 +54,11 @@ class ProjectHooks < Spinach::FeatureSteps text: 'Hook execution failed. '\ 'Ensure the project has commits.' end + + step 'I should see hook service down error message' do + page.should have_selector '.flash-alert', + text: 'Hook execution failed. '\ + 'Ensure hook URL is correct and '\ + 'service is up.' + end end -- cgit v1.2.1