From fac3c91728457a4ee57dcf789aac27462e295e43 Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Mon, 31 Jul 2017 14:00:52 -0500 Subject: Add specific code review guidelines --- doc/development/code_review.md | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'doc') diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e3f37616757..23313446d34 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -9,8 +9,16 @@ There are a few rules to get your merge request accepted: **approved by a [backend maintainer][projects]**. 1. If your merge request includes only frontend changes [^1], it must be **approved by a [frontend maintainer][projects]**. + 1. If your merge request includes UX changes [^1], it must + be **approved by a [UX team member][team]**. + 1. If your merge request includes adding a new JavaScript library [^1], it must be + **approved by a [frontend lead][team]**. 1. If your merge request includes frontend and backend changes [^1], it must be **approved by a [frontend and a backend maintainer][projects]**. + 1. If your merge request includes UX and frontend changes [^1], it must + be **approved by a [UX team member and a frontend maintainer][team]**. + 1. If your merge request includes UX, frontend and backend changes [^1], it must + be **approved by a [UX team member, a frontend and a backend maintainer][team]**. 1. To lower the amount of merge requests maintainers need to review, you can ask or assign any [reviewers][projects] for a first review. 1. If you need some guidance (e.g. it's your first merge request), feel free -- cgit v1.2.1 From c4e7875d2909588e55c21a7cf19e31f60bce200f Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Mon, 31 Jul 2017 15:19:51 -0500 Subject: Add note about UX paradigm --- doc/development/code_review.md | 2 ++ 1 file changed, 2 insertions(+) (limited to 'doc') diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 23313446d34..9fc6759b58a 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -13,6 +13,8 @@ There are a few rules to get your merge request accepted: be **approved by a [UX team member][team]**. 1. If your merge request includes adding a new JavaScript library [^1], it must be **approved by a [frontend lead][team]**. + 1. If your merge request includes adding a new UI/UX paradigm [^1], it must be + **approved by a [UX lead][team]**. 1. If your merge request includes frontend and backend changes [^1], it must be **approved by a [frontend and a backend maintainer][projects]**. 1. If your merge request includes UX and frontend changes [^1], it must -- cgit v1.2.1