From 22bf3848ef0e59fb7689bfeab3ba0d8079f1597e Mon Sep 17 00:00:00 2001 From: Michael Kozono Date: Thu, 20 Sep 2018 12:38:00 -0700 Subject: Add note to docs about `Gitlab::SafeRequestStore` --- doc/development/merge_request_performance_guidelines.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'doc/development') diff --git a/doc/development/merge_request_performance_guidelines.md b/doc/development/merge_request_performance_guidelines.md index 12badbe39b2..ee01c89e0ed 100644 --- a/doc/development/merge_request_performance_guidelines.md +++ b/doc/development/merge_request_performance_guidelines.md @@ -168,6 +168,7 @@ user objects for every username we can remove the need for running the same query for every mention of `@alice`. Caching data per transaction can be done using -[RequestStore](https://github.com/steveklabnik/request_store). Caching data in -Redis can be done using [Rails' caching +[RequestStore](https://github.com/steveklabnik/request_store) (use +`Gitlab::SafeRequestStore` to avoid having to remember to check +`RequestStore.active?`). Caching data in Redis can be done using [Rails' caching system](http://guides.rubyonrails.org/caching_with_rails.html). -- cgit v1.2.1