From 309ca405fa30e1eeaeaeddc0c8918e65c98ebbf7 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Mon, 2 May 2016 18:15:25 +0200 Subject: Don't modify arguments in CommitRange#initialize This method used to call strip! on input strings which will mess with the strings if they're re-used or frozen. --- app/models/commit_range.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/models/commit_range.rb') diff --git a/app/models/commit_range.rb b/app/models/commit_range.rb index 51673897d98..4066958f67c 100644 --- a/app/models/commit_range.rb +++ b/app/models/commit_range.rb @@ -62,7 +62,7 @@ class CommitRange def initialize(range_string, project) @project = project - range_string.strip! + range_string = range_string.strip unless range_string =~ /\A#{PATTERN}\z/ raise ArgumentError, "invalid CommitRange string format: #{range_string}" -- cgit v1.2.1