From 91939161aace35823f7a60b25647d5e23285c556 Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Mon, 15 Jan 2018 15:00:58 +0000 Subject: Only highlight search results under the highlighting size limit We should use this limit everywhere, but especially in project search results, where we could be highlighting very long single lines. (Typical examples: minified JavaScript, and JSON data files.) --- app/helpers/blob_helper.rb | 2 ++ 1 file changed, 2 insertions(+) (limited to 'app/helpers/blob_helper.rb') diff --git a/app/helpers/blob_helper.rb b/app/helpers/blob_helper.rb index 5e3b2e5581c..a6e1de6ffdc 100644 --- a/app/helpers/blob_helper.rb +++ b/app/helpers/blob_helper.rb @@ -1,6 +1,8 @@ module BlobHelper def highlight(blob_name, blob_content, repository: nil, plain: false) + plain ||= blob_content.length > Blob::MAXIMUM_TEXT_HIGHLIGHT_SIZE highlighted = Gitlab::Highlight.highlight(blob_name, blob_content, plain: plain, repository: repository) + raw %(
#{highlighted}
) end -- cgit v1.2.1