From 48d0426aeddf6a3412786b687880ec5d64691b43 Mon Sep 17 00:00:00 2001
From: Bryce Johnson <bryce@gitlab.com>
Date: Sat, 6 May 2017 01:18:00 -0400
Subject: Use Visibility.js in SmartInterval.

---
 app/assets/javascripts/smart_interval.js | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

(limited to 'app/assets/javascripts/smart_interval.js')

diff --git a/app/assets/javascripts/smart_interval.js b/app/assets/javascripts/smart_interval.js
index d1bdc353be2..c366262a6e7 100644
--- a/app/assets/javascripts/smart_interval.js
+++ b/app/assets/javascripts/smart_interval.js
@@ -1,3 +1,5 @@
+import Visibility from 'visibilityjs';
+
 /*
 * Instances of SmartInterval extend the functionality of `setInterval`, make it configurable
 * and controllable by a public API.
@@ -32,7 +34,6 @@
       this.state = {
         intervalId: null,
         currentInterval: this.cfg.startingInterval,
-        pageVisibility: 'visible',
       };
 
       this.initInterval();
@@ -88,8 +89,7 @@
 
     destroy() {
       this.cancel();
-      document.removeEventListener('visibilitychange', this.handleVisibilityChange);
-      $(document).off('visibilitychange').off('beforeunload');
+      Visibility.unbind(this.handleVisibilityChange);
     }
 
     /* private */
@@ -107,7 +107,7 @@
 
     initVisibilityChangeHandling() {
       // cancel interval when tab no longer shown (prevents cached pages from polling)
-      document.addEventListener('visibilitychange', this.handleVisibilityChange.bind(this));
+      Visibility.change((e, state) => this.handleVisibilityChange(e, state));
     }
 
     initPageUnloadHandling() {
@@ -116,9 +116,8 @@
       $(document).on('beforeunload', () => this.cancel());
     }
 
-    handleVisibilityChange(e) {
-      this.state.pageVisibility = e.target.visibilityState;
-      const intervalAction = this.isPageVisible() ?
+    handleVisibilityChange(e, state) {
+      const intervalAction = state === 'visible' ?
         this.onVisibilityVisible :
         this.onVisibilityHidden;
 
@@ -136,7 +135,7 @@
     incrementInterval() {
       const cfg = this.cfg;
       const currentInterval = this.getCurrentInterval();
-      if (cfg.hiddenInterval && !this.isPageVisible()) return;
+      if (cfg.hiddenInterval && Visibility.hidden()) return;
       let nextInterval = currentInterval * cfg.incrementByFactorOf;
 
       if (nextInterval > cfg.maxInterval) {
@@ -146,8 +145,6 @@
       this.setCurrentInterval(nextInterval);
     }
 
-    isPageVisible() { return this.state.pageVisibility === 'visible'; }
-
     stopTimer() {
       const state = this.state;
 
-- 
cgit v1.2.1