From fa6df2228e7d8957db4b37a44b687c71aac52449 Mon Sep 17 00:00:00 2001 From: Patricio Cano Date: Mon, 14 Sep 2015 20:50:13 -0500 Subject: Replaced `this` with `@` in the coffee file and added an arrow that clearly marks the Notifications button as a drop down --- app/assets/javascripts/project.js.coffee | 6 +++--- app/views/projects/buttons/_notifications.html.haml | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/project.js.coffee b/app/assets/javascripts/project.js.coffee index f524627e0be..e187ec6ab77 100644 --- a/app/assets/javascripts/project.js.coffee +++ b/app/assets/javascripts/project.js.coffee @@ -27,8 +27,8 @@ class @Project $('.update-notification').on 'click', (e) -> e.preventDefault() - level = $(this).data('notification-level') + level = $(@).data 'notification-level' $('#notification_level').val(level) $('#notification-form').submit() - $(this).parents('ul').find('li.active').removeClass('active') - $(this).parent().addClass('active') \ No newline at end of file + $(@).parents('ul').find('li.active').removeClass 'active' + $(@).parent().addClass 'active' \ No newline at end of file diff --git a/app/views/projects/buttons/_notifications.html.haml b/app/views/projects/buttons/_notifications.html.haml index 6d9d48994e1..e782aeb3616 100644 --- a/app/views/projects/buttons/_notifications.html.haml +++ b/app/views/projects/buttons/_notifications.html.haml @@ -7,6 +7,7 @@ %a.dropdown-toggle.btn.btn-new{href: '#', "data-toggle" => "dropdown"} = icon('bell') Notifications + = icon('angle-down') %ul.dropdown-menu.dropdown-menu-right.project-home-dropdown - Notification.notification_levels.each do |level| = notification_list_item(level, @membership) \ No newline at end of file -- cgit v1.2.1