From 3a38ec323d617ed3a34dfce3a2d60ccbb6004e4e Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Fri, 9 Nov 2018 16:37:22 +0100 Subject: Dangerbot: mention tech writers based on DevOps stage --- danger/documentation/Dangerfile | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/danger/documentation/Dangerfile b/danger/documentation/Dangerfile index fe819ee250c..f5923a22af9 100644 --- a/danger/documentation/Dangerfile +++ b/danger/documentation/Dangerfile @@ -24,9 +24,19 @@ The following files require a review from the Documentation team: * #{docs_paths_to_review.map { |path| "`#{path}`" }.join("\n* ")} -To make sure these changes are reviewed, mention `@gl-docsteam` in a separate -comment, and explain what needs to be reviewed by the team. Please don't mention -the team until your changes are ready for review. +To make sure these changes are reviewed, mention a technical writer in a separate +comment, and explain what needs to be reviewed. Please don't mention them +until your changes are ready for review. + +Who to ping [based on DevOps stages](https://about.gitlab.com/handbook/product/categories/#devops-stages): + +- `@axil`: ~Distribution ~Packaging ~Monitoring ~Secure ~Gitaly ~Gitter +- `@eread`: ~Manage ~Geo ~Verify ~Configure +- `@marcia`: ~Create ~Release +- `@mikelewis`: ~Plan + +If you don't know who to ping, or your change doesn't fall under one of the above +categories, you can mention the whole team with `@gl-docsteam`. MARKDOWN unless gitlab.mr_labels.include?('Documentation') -- cgit v1.2.1 From ce9e3b891bd767702e9063f7aba7e7bb4cb88643 Mon Sep 17 00:00:00 2001 From: Mike Lewis Date: Fri, 9 Nov 2018 18:55:27 +0000 Subject: Edits to docs Dangerfile --- danger/documentation/Dangerfile | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/danger/documentation/Dangerfile b/danger/documentation/Dangerfile index f5923a22af9..422f2cb2551 100644 --- a/danger/documentation/Dangerfile +++ b/danger/documentation/Dangerfile @@ -24,19 +24,30 @@ The following files require a review from the Documentation team: * #{docs_paths_to_review.map { |path| "`#{path}`" }.join("\n* ")} -To make sure these changes are reviewed, mention a technical writer in a separate -comment, and explain what needs to be reviewed. Please don't mention them -until your changes are ready for review. +When your content is ready for review, mention a technical writer in a separate +comment and explain what needs to be reviewed. -Who to ping [based on DevOps stages](https://about.gitlab.com/handbook/product/categories/#devops-stages): +You are welcome to mention them sooner if you have questions about writing or updating +the documentation. GitLabbers are also welcome to use the [#docs](https://gitlab.slack.com/archives/C16HYA2P5) channel on Slack. -- `@axil`: ~Distribution ~Packaging ~Monitoring ~Secure ~Gitaly ~Gitter -- `@eread`: ~Manage ~Geo ~Verify ~Configure -- `@marcia`: ~Create ~Release -- `@mikelewis`: ~Plan +Who to ping [based on DevOps stages](https://about.gitlab.com/handbook/product/categories/#devops-stages): -If you don't know who to ping, or your change doesn't fall under one of the above -categories, you can mention the whole team with `@gl-docsteam`. +| ~Create | @`marcia` | +| ~Configure | `@eread | +| ~Distribution | `@axil` | +| ~Geo | `@eread | +| ~Gitaly | `@axil` | +| ~Gitter | `@axil` | +| ~Manage | `@eread | +| ~Monitoring | `@axil` | +| ~Packaging | `@axil` | +| ~Plan | `@mikelewis | +| ~Release | `marcia` | +| ~Secure | `@axil` | +| ~Verify | `@eread | + +If you are not sure which category the change falls within, or the change is not +part of one of these categories, you can mention the whole team with `@gl-docsteam`. MARKDOWN unless gitlab.mr_labels.include?('Documentation') -- cgit v1.2.1 From bcb2c6de63ddf841de902be0ce1ee153c2b50fe4 Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Mon, 12 Nov 2018 10:09:02 +0100 Subject: Proper markdown table in docs Dangerfile --- danger/documentation/Dangerfile | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/danger/documentation/Dangerfile b/danger/documentation/Dangerfile index 422f2cb2551..1ee025f0972 100644 --- a/danger/documentation/Dangerfile +++ b/danger/documentation/Dangerfile @@ -27,24 +27,26 @@ The following files require a review from the Documentation team: When your content is ready for review, mention a technical writer in a separate comment and explain what needs to be reviewed. -You are welcome to mention them sooner if you have questions about writing or updating +You are welcome to mention them sooner if you have questions about writing or updating the documentation. GitLabbers are also welcome to use the [#docs](https://gitlab.slack.com/archives/C16HYA2P5) channel on Slack. Who to ping [based on DevOps stages](https://about.gitlab.com/handbook/product/categories/#devops-stages): -| ~Create | @`marcia` | -| ~Configure | `@eread | -| ~Distribution | `@axil` | -| ~Geo | `@eread | -| ~Gitaly | `@axil` | -| ~Gitter | `@axil` | -| ~Manage | `@eread | -| ~Monitoring | `@axil` | -| ~Packaging | `@axil` | -| ~Plan | `@mikelewis | -| ~Release | `marcia` | -| ~Secure | `@axil` | -| ~Verify | `@eread | +| Stage | Tech writer | +| ------------- | ----------- | +| ~Create | `@marcia` | +| ~Configure | `@eread` | +| ~Distribution | `@axil` | +| ~Geo | `@eread` | +| ~Gitaly | `@axil` | +| ~Gitter | `@axil` | +| ~Manage | `@eread` | +| ~Monitoring | `@axil` | +| ~Packaging | `@axil` | +| ~Plan | `@mikelewis`| +| ~Release | `marcia` | +| ~Secure | `@axil` | +| ~Verify | `@eread` | If you are not sure which category the change falls within, or the change is not part of one of these categories, you can mention the whole team with `@gl-docsteam`. -- cgit v1.2.1