From e39b45badd3f69a345cd5fc5d7379c94b42d5902 Mon Sep 17 00:00:00 2001 From: lauraMon Date: Thu, 5 Sep 2019 13:13:22 -0400 Subject: Removes unnecessary test and adds disable rule --- .../monitoring/components/dashboard_spec.js | 26 ++++------------------ 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/spec/frontend/monitoring/components/dashboard_spec.js b/spec/frontend/monitoring/components/dashboard_spec.js index 70c8a84f75d..2a8e0240bf9 100644 --- a/spec/frontend/monitoring/components/dashboard_spec.js +++ b/spec/frontend/monitoring/components/dashboard_spec.js @@ -5,7 +5,7 @@ import MockAdapter from 'axios-mock-adapter'; import Dashboard from '~/monitoring/components/dashboard.vue'; import GraphGroup from '~/monitoring/components/graph_group.vue'; import EmptyState from '~/monitoring/components/empty_state.vue'; -import { timeWindows, timeWindowsKeyNames } from '~/monitoring/constants'; +import { timeWindows } from '~/monitoring/constants'; import * as types from '~/monitoring/stores/mutation_types'; import { createStore } from '~/monitoring/stores'; import axios from '~/lib/utils/axios_utils'; @@ -20,6 +20,9 @@ import MonitoringMock, { dashboardGitResponse, } from '../../../../spec/javascripts/monitoring/mock_data'; +/* eslint-disable no-unused-vars */ +/* eslint-disable no-undef */ +// see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32571#note_211860465 function setupComponentStore(component) { component.$store.commit( `monitoringDashboard/${types.RECEIVE_METRICS_DATA_SUCCESS}`, @@ -367,27 +370,6 @@ describe('Dashboard', () => { done(); }); }); - - it('defaults to the eight hours time window for non valid url parameters', () => { - urlUtility.getParameterValues.mockReturnValue(['']); - spyOn(store, 'dispatch').and.returnValue(Promise.resolve()); - - const wrapper = shallowMount(DashboardComponent, { - propsData: { - ...propsData, - hasMetrics: true, - showPanels: false, - }, - store, - sync: false, - localVue, - }); - - expect(store.dispatch).toHaveBeenCalledWith('monitoringDashboard/fetchData', { - end: '', - start: '', - }); - }); }); describe('link to chart', () => { -- cgit v1.2.1