From e202a6bdd414f9cc1c44f522b85e79628a34db4b Mon Sep 17 00:00:00 2001
From: Yorick Peterse <yorickpeterse@gmail.com>
Date: Wed, 6 Jan 2016 15:30:02 +0100
Subject: Store SQL/view timings in milliseconds

Transaction timings are also already stored in milliseconds, this keeps
things consistent.
---
 lib/gitlab/metrics/subscribers/action_view.rb             | 8 ++++++--
 lib/gitlab/metrics/subscribers/active_record.rb           | 6 +++++-
 spec/lib/gitlab/metrics/subscribers/action_view_spec.rb   | 4 ++--
 spec/lib/gitlab/metrics/subscribers/active_record_spec.rb | 2 +-
 4 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/lib/gitlab/metrics/subscribers/action_view.rb b/lib/gitlab/metrics/subscribers/action_view.rb
index 7c0105d543a..84d9e383625 100644
--- a/lib/gitlab/metrics/subscribers/action_view.rb
+++ b/lib/gitlab/metrics/subscribers/action_view.rb
@@ -19,7 +19,7 @@ module Gitlab
           values = values_for(event)
           tags   = tags_for(event)
 
-          current_transaction.increment(:view_duration, event.duration)
+          current_transaction.increment(:view_duration, duration(event))
           current_transaction.add_metric(SERIES, values, tags)
         end
 
@@ -28,7 +28,7 @@ module Gitlab
         end
 
         def values_for(event)
-          { duration: event.duration }
+          { duration: duration(event) }
         end
 
         def tags_for(event)
@@ -48,6 +48,10 @@ module Gitlab
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end
diff --git a/lib/gitlab/metrics/subscribers/active_record.rb b/lib/gitlab/metrics/subscribers/active_record.rb
index 8008b3bc895..6fa73e7a3be 100644
--- a/lib/gitlab/metrics/subscribers/active_record.rb
+++ b/lib/gitlab/metrics/subscribers/active_record.rb
@@ -8,7 +8,7 @@ module Gitlab
         def sql(event)
           return unless current_transaction
 
-          current_transaction.increment(:sql_duration, event.duration)
+          current_transaction.increment(:sql_duration, duration(event))
         end
 
         private
@@ -16,6 +16,10 @@ module Gitlab
         def current_transaction
           Transaction.current
         end
+
+        def duration(event)
+          event.duration * 1000.0
+        end
       end
     end
   end
diff --git a/spec/lib/gitlab/metrics/subscribers/action_view_spec.rb b/spec/lib/gitlab/metrics/subscribers/action_view_spec.rb
index 05e4fbbeb51..0a4cc5e929b 100644
--- a/spec/lib/gitlab/metrics/subscribers/action_view_spec.rb
+++ b/spec/lib/gitlab/metrics/subscribers/action_view_spec.rb
@@ -21,7 +21,7 @@ describe Gitlab::Metrics::Subscribers::ActionView do
 
   describe '#render_template' do
     it 'tracks rendering of a template' do
-      values = { duration: 2.1 }
+      values = { duration: 2100 }
       tags   = {
         view: 'app/views/x.html.haml',
         file: 'app/views/x.html.haml',
@@ -29,7 +29,7 @@ describe Gitlab::Metrics::Subscribers::ActionView do
       }
 
       expect(transaction).to receive(:increment).
-        with(:view_duration, 2.1)
+        with(:view_duration, 2100)
 
       expect(transaction).to receive(:add_metric).
         with(described_class::SERIES, values, tags)
diff --git a/spec/lib/gitlab/metrics/subscribers/active_record_spec.rb b/spec/lib/gitlab/metrics/subscribers/active_record_spec.rb
index 7bc070a4d09..ca86142a2f4 100644
--- a/spec/lib/gitlab/metrics/subscribers/active_record_spec.rb
+++ b/spec/lib/gitlab/metrics/subscribers/active_record_spec.rb
@@ -26,7 +26,7 @@ describe Gitlab::Metrics::Subscribers::ActiveRecord do
           and_return(transaction)
 
         expect(transaction).to receive(:increment).
-          with(:sql_duration, 0.2)
+          with(:sql_duration, 200)
 
         subscriber.sql(event)
       end
-- 
cgit v1.2.1