From 8f335b27b04d1a862f654cd99cce0f5ee98b63af Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Mon, 5 Mar 2018 16:39:23 +0000 Subject: Add how to manage a regression --- PROCESS.md | 36 +++++++++++++++++++++++++++++++----- 1 file changed, 31 insertions(+), 5 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index a46fd8c25b4..5fdab3ed382 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -15,6 +15,8 @@ - [Between the 1st and the 7th](#between-the-1st-and-the-7th) - [On the 7th](#on-the-7th) - [After the 7th](#after-the-7th) +- [Regressions](#regressions) + - [How to manage a regression](#how-to-manage-a-regression) - [Release retrospective and kickoff](#release-retrospective-and-kickoff) - [Retrospective](#retrospective) - [Kickoff](#kickoff) @@ -216,7 +218,7 @@ For example, it is likely that an exception will be made for a trivial 1-5 line All MRs which have had exceptions granted must be merged by the 15th. -### Regressions +## Regressions A regression for a particular monthly release is a bug that exists in that release, but wasn't present in the release before. This includes bugs in @@ -234,10 +236,33 @@ month. When we say 'the most recent monthly release', this can refer to either the version currently running on GitLab.com, or the most recent version available in the package repositories. -A regression issue should be labeled with the appropriate [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) -and [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), -just like any other issue, to help GitLab team members focus on issues that are -relevant to [their area of responsibility](https://about.gitlab.com/handbook/engineering/workflow/#choosing-something-to-work-on). +### How to manage a regression + +Regressions are very important, and they should be considered high priority +issues that should be solved as soon as possible, expecially if they affect +users. Anyway, ~regression label itself is not a [priority label], and this +means that regressions should still follow the scheduling process. + +When a regression is found: +1. Create an issue describing the problem in the most detailed way possible +2. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), + the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) + and any other label that may apply in the specific case +3. Add the ~regression label +4. Add the proper milestone +4. Ping the Product Manager, see [product categories](https://about.gitlab.com/handbook/product/categories/) + to find who manages that specific area of the Product + +A very important step is helping the PM to understand the impact the regression +may have on users, by providing examples and how to reproduce it. This will +allow proper scheduling with a [priority label]. Normally it will be +~"Next Patch Release" if after the final release, or ~Deliverable if between the +feature freeze and the final release. + +In case of very urgent fixes, a developer can choose to pick up the issue even +before it is properly scheduled, in order to speed up the process. The PM should +be pinged in the issue anyway to get confirmation about the actual priority as +soon as possible. ## Release retrospective and kickoff @@ -312,3 +337,4 @@ still an issue I encourage you to open it on the [GitLab.com issue tracker](http [done]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done [automatic_ce_ee_merge]: https://docs.gitlab.com/ce/development/automatic_ce_ee_merge.html [ee_features]: https://docs.gitlab.com/ce/development/ee_features.html +[priority label]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#priority-labels-deliverable-stretch-next-patch-release -- cgit v1.2.1 From b272518db3574ee6d2577e3f31d6b98563278d1e Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Mon, 5 Mar 2018 16:42:24 +0000 Subject: Copyedit --- PROCESS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 5fdab3ed382..6da55b632fe 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -250,7 +250,8 @@ When a regression is found: and any other label that may apply in the specific case 3. Add the ~regression label 4. Add the proper milestone -4. Ping the Product Manager, see [product categories](https://about.gitlab.com/handbook/product/categories/) +4. Ping the Product Manager for proper scheduling, see + [product categories](https://about.gitlab.com/handbook/product/categories/) to find who manages that specific area of the Product A very important step is helping the PM to understand the impact the regression -- cgit v1.2.1 From a0e5c299e371ada2ff0229e09dbb002f51970794 Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Fri, 9 Mar 2018 14:49:39 +0000 Subject: Simplified the process --- PROCESS.md | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 6da55b632fe..29e66284989 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -240,8 +240,7 @@ available in the package repositories. Regressions are very important, and they should be considered high priority issues that should be solved as soon as possible, expecially if they affect -users. Anyway, ~regression label itself is not a [priority label], and this -means that regressions should still follow the scheduling process. +users. Anyway, ~regression label itself is not a [priority label]. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible @@ -250,20 +249,17 @@ When a regression is found: and any other label that may apply in the specific case 3. Add the ~regression label 4. Add the proper milestone -4. Ping the Product Manager for proper scheduling, see - [product categories](https://about.gitlab.com/handbook/product/categories/) - to find who manages that specific area of the Product + +If the regression is relevant and not just a minor fix, ping the Product Manager +in the issue, see [product categories](https://about.gitlab.com/handbook/product/categories/) +to find who manages that specific area of the Product. In case you are in doubt +to ping or not, do it. A very important step is helping the PM to understand the impact the regression may have on users, by providing examples and how to reproduce it. This will -allow proper scheduling with a [priority label]. Normally it will be -~"Next Patch Release" if after the final release, or ~Deliverable if between the -feature freeze and the final release. - -In case of very urgent fixes, a developer can choose to pick up the issue even -before it is properly scheduled, in order to speed up the process. The PM should -be pinged in the issue anyway to get confirmation about the actual priority as -soon as possible. +allow proper scheduling. Feel free to put ~"Next Patch Release" label to the +issue so the fix can start immediately, the PM will discuss and prioritize it as +needed if necessary. ## Release retrospective and kickoff -- cgit v1.2.1 From bd0f9cd61c6daedf84eaef88e82572000c6eabfc Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Mon, 12 Mar 2018 15:13:14 +0000 Subject: Copyedit --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 29e66284989..bf9e4b203c7 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -239,7 +239,7 @@ available in the package repositories. ### How to manage a regression Regressions are very important, and they should be considered high priority -issues that should be solved as soon as possible, expecially if they affect +issues that should be solved as soon as possible, especially if they affect users. Anyway, ~regression label itself is not a [priority label]. When a regression is found: -- cgit v1.2.1 From b67fc550d866e6519260519c6d4663736043d2da Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Mon, 12 Mar 2018 15:15:05 +0000 Subject: Copyedits --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index bf9e4b203c7..03b888ece9d 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -240,7 +240,7 @@ available in the package repositories. Regressions are very important, and they should be considered high priority issues that should be solved as soon as possible, especially if they affect -users. Anyway, ~regression label itself is not a [priority label]. +users. Despite that, ~regression label itself is not a [priority label]. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible -- cgit v1.2.1 From 7c9c865179bf2a5dfb12d8e594c9695d64d33678 Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Mon, 12 Mar 2018 15:26:52 +0000 Subject: Add bug label too --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 03b888ece9d..df415f3b9a7 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -247,7 +247,7 @@ When a regression is found: 2. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case -3. Add the ~regression label +3. Add the ~bug and ~regression labels 4. Add the proper milestone If the regression is relevant and not just a minor fix, ping the Product Manager -- cgit v1.2.1 From bec95d6af5bc11d93382ca94566f90927bbd00d3 Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Mon, 12 Mar 2018 15:39:58 +0000 Subject: Better clarify the process --- PROCESS.md | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index df415f3b9a7..7c1ace4b758 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -244,22 +244,17 @@ users. Despite that, ~regression label itself is not a [priority label]. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible -2. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), +1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case -3. Add the ~bug and ~regression labels -4. Add the proper milestone - -If the regression is relevant and not just a minor fix, ping the Product Manager -in the issue, see [product categories](https://about.gitlab.com/handbook/product/categories/) -to find who manages that specific area of the Product. In case you are in doubt -to ping or not, do it. - -A very important step is helping the PM to understand the impact the regression -may have on users, by providing examples and how to reproduce it. This will -allow proper scheduling. Feel free to put ~"Next Patch Release" label to the -issue so the fix can start immediately, the PM will discuss and prioritize it as -needed if necessary. +1. Add the ~bug and ~regression labels +1. Add the proper milestone +1. If possible, provide links to real examples and how to reproduce the problem + +Feel free to put ~"Next Patch Release" label to the issue so the fix can start +as soon as possible. You can ping the Engineering Manager or the Product Manager +for the relative area area to make them aware of the issue earlier. They will +analyze the priority and take proper actions if needed. ## Release retrospective and kickoff -- cgit v1.2.1 From 34f47303005640acd912712944780b02cf219cb6 Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Mon, 12 Mar 2018 20:56:44 +0000 Subject: Fix typo --- PROCESS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 7c1ace4b758..4e8fec32041 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -253,8 +253,8 @@ When a regression is found: Feel free to put ~"Next Patch Release" label to the issue so the fix can start as soon as possible. You can ping the Engineering Manager or the Product Manager -for the relative area area to make them aware of the issue earlier. They will -analyze the priority and take proper actions if needed. +for the relative area to make them aware of the issue earlier. They will analyze +the priority and take proper actions if needed. ## Release retrospective and kickoff -- cgit v1.2.1 From d7db1fd597abe4aa1228b944be8884306292aae0 Mon Sep 17 00:00:00 2001 From: "Fabio Busatto (OOO until 19/3)" Date: Wed, 14 Mar 2018 14:30:58 +0000 Subject: Explain milestone usage --- PROCESS.md | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 4e8fec32041..ccde094412f 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -244,17 +244,21 @@ users. Despite that, ~regression label itself is not a [priority label]. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible +1. If possible, provide links to real examples and how to reproduce the problem 1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case 1. Add the ~bug and ~regression labels -1. Add the proper milestone -1. If possible, provide links to real examples and how to reproduce the problem - -Feel free to put ~"Next Patch Release" label to the issue so the fix can start -as soon as possible. You can ping the Engineering Manager or the Product Manager -for the relative area to make them aware of the issue earlier. They will analyze -the priority and take proper actions if needed. +1. Add the proper milestone and priority label: + - If the issue is for a feature that was introduced in the previous release. + label with the previous milestone and ~"Next Patch Release" + - If the issue is for a feature that is introduced in a RC version for the + current release, label with the current milestone and ~"Deliverable" + +When a new issue is found, the fix should start as soon as possible. You can +ping the Engineering Manager or the Product Manager for the relative area to +make them aware of the issue earlier. They will analyze the priority and change +it if needed. ## Release retrospective and kickoff -- cgit v1.2.1 From 2e88192bb329353630207ef7843e0c47ea11519b Mon Sep 17 00:00:00 2001 From: bikebilly Date: Mon, 18 Jun 2018 08:38:16 -0400 Subject: Update regression labeling --- PROCESS.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index ccde094412f..a1c2337be0c 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -249,11 +249,11 @@ When a regression is found: the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case 1. Add the ~bug and ~regression labels +1. Evaluate the Severity of the regression and add a Severity level 1. Add the proper milestone and priority label: - - If the issue is for a feature that was introduced in the previous release. - label with the previous milestone and ~"Next Patch Release" - - If the issue is for a feature that is introduced in a RC version for the - current release, label with the current milestone and ~"Deliverable" + - If the regression is ~S1 or ~S2, label set the current milestone + - If the regression was introduced in a RC of the current release, label with ~Deliverable + - If the regression was introduced in the previos release, label with ~"Next Patch Release" When a new issue is found, the fix should start as soon as possible. You can ping the Engineering Manager or the Product Manager for the relative area to -- cgit v1.2.1 From 07d1a7f012a6e04b5b36712685cccfb95e6dc1c4 Mon Sep 17 00:00:00 2001 From: bikebilly Date: Mon, 18 Jun 2018 08:50:45 -0400 Subject: Update regression labeling --- PROCESS.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index a1c2337be0c..23f800d70f5 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -249,9 +249,10 @@ When a regression is found: the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case 1. Add the ~bug and ~regression labels -1. Evaluate the Severity of the regression and add a Severity level -1. Add the proper milestone and priority label: - - If the regression is ~S1 or ~S2, label set the current milestone +1. Evaluate the severity and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels-s1-s2-s3-s4) +1. Evaluate the priority and add a [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels-p1-p2-p3-p4) +1. Schedule the issue in order to get it fixed as soon as possible, based on severity and priority, following these guidelines: + - If the regression is ~S1 or ~S2, set the current milestone - If the regression was introduced in a RC of the current release, label with ~Deliverable - If the regression was introduced in the previos release, label with ~"Next Patch Release" -- cgit v1.2.1 From f0607059b6a2b87cda36c70b2bce30d11e18bd3c Mon Sep 17 00:00:00 2001 From: bikebilly Date: Mon, 18 Jun 2018 08:53:51 -0400 Subject: Update regression labeling --- PROCESS.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 23f800d70f5..bbb239800ad 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -253,8 +253,9 @@ When a regression is found: 1. Evaluate the priority and add a [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels-p1-p2-p3-p4) 1. Schedule the issue in order to get it fixed as soon as possible, based on severity and priority, following these guidelines: - If the regression is ~S1 or ~S2, set the current milestone - - If the regression was introduced in a RC of the current release, label with ~Deliverable - - If the regression was introduced in the previos release, label with ~"Next Patch Release" + - If the regression was introduced in a RC of the current release, label with ~Deliverable + - If the regression was introduced in the previos release, label with ~"Next Patch Release" + - If the regression is ~S3 or ~S4, it can be scheduled for later milestones When a new issue is found, the fix should start as soon as possible. You can ping the Engineering Manager or the Product Manager for the relative area to -- cgit v1.2.1 From 7b1c34732317d9df8d17bbd85aa26a1c02623156 Mon Sep 17 00:00:00 2001 From: bikebilly Date: Mon, 18 Jun 2018 14:39:20 -0400 Subject: Copyedits --- PROCESS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index bbb239800ad..c730cb918d9 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -240,7 +240,8 @@ available in the package repositories. Regressions are very important, and they should be considered high priority issues that should be solved as soon as possible, especially if they affect -users. Despite that, ~regression label itself is not a [priority label]. +users. Despite that, ~regression label itself is not implying when the issue +will be scheduled. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible @@ -335,4 +336,3 @@ still an issue I encourage you to open it on the [GitLab.com issue tracker](http [done]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#definition-of-done [automatic_ce_ee_merge]: https://docs.gitlab.com/ce/development/automatic_ce_ee_merge.html [ee_features]: https://docs.gitlab.com/ce/development/ee_features.html -[priority label]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#priority-labels-deliverable-stretch-next-patch-release -- cgit v1.2.1 From 4c77257a33867f7532b134be5ee49a269341e072 Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Wed, 20 Jun 2018 15:13:41 +0000 Subject: Copyedits --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index c730cb918d9..2c081a0cecc 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -255,7 +255,7 @@ When a regression is found: 1. Schedule the issue in order to get it fixed as soon as possible, based on severity and priority, following these guidelines: - If the regression is ~S1 or ~S2, set the current milestone - If the regression was introduced in a RC of the current release, label with ~Deliverable - - If the regression was introduced in the previos release, label with ~"Next Patch Release" + - If the regression was introduced in the previous release, label with ~"Next Patch Release" - If the regression is ~S3 or ~S4, it can be scheduled for later milestones When a new issue is found, the fix should start as soon as possible. You can -- cgit v1.2.1 From 3739c1b9d4aa878b5766b8e196a5952160340972 Mon Sep 17 00:00:00 2001 From: bikebilly Date: Wed, 20 Jun 2018 23:14:27 -0400 Subject: Copyedits --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 2c081a0cecc..d09f6a41899 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -240,7 +240,7 @@ available in the package repositories. Regressions are very important, and they should be considered high priority issues that should be solved as soon as possible, especially if they affect -users. Despite that, ~regression label itself is not implying when the issue +users. Despite that, ~regression label itself does not imply when the issue will be scheduled. When a regression is found: -- cgit v1.2.1 From c5073e67f4d0d777b3015ad1f6bde6d69815df6b Mon Sep 17 00:00:00 2001 From: bikebilly Date: Wed, 20 Jun 2018 23:16:46 -0400 Subject: Copyedits --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index d09f6a41899..965a3b62873 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -246,7 +246,7 @@ will be scheduled. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible 1. If possible, provide links to real examples and how to reproduce the problem -1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels-ci-discussion-edge-platform-etc), +1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels), the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case 1. Add the ~bug and ~regression labels -- cgit v1.2.1 From d18c1bce6a0a8fe4161425550504bbd3ed25a1eb Mon Sep 17 00:00:00 2001 From: bikebilly Date: Fri, 22 Jun 2018 10:55:25 -0400 Subject: Update regression labeling process --- PROCESS.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 965a3b62873..539cc4a243b 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -249,14 +249,14 @@ When a regression is found: 1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels), the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) and any other label that may apply in the specific case -1. Add the ~bug and ~regression labels -1. Evaluate the severity and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels-s1-s2-s3-s4) -1. Evaluate the priority and add a [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels-p1-p2-p3-p4) -1. Schedule the issue in order to get it fixed as soon as possible, based on severity and priority, following these guidelines: - - If the regression is ~S1 or ~S2, set the current milestone - - If the regression was introduced in a RC of the current release, label with ~Deliverable - - If the regression was introduced in the previous release, label with ~"Next Patch Release" - - If the regression is ~S3 or ~S4, it can be scheduled for later milestones + + +1. Add the bug and regression labels +1. Notify the respective Engineering Manager to evaluate the Severity of the regression and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels-s1-s2-s3-s4). The counterpart Product Manager is included to weigh-in on prioritization as needed to set the [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels-p1-p2-p3-p4). +1. If the regression is a ~S1 or ~S2, label the regression with the current milestone as it should be fixed in the current milestone. + 1. If the regression was introduced in an RC of the current release, label with ~Deliverable + 1. If the regression was introduced in the previous release, label with ~"Next Patch Release" +1. If the regression is a ~S3 or ~S4, the regression may be scheduled for later milestones at the discretion of Engineering Manager and Product Manager. When a new issue is found, the fix should start as soon as possible. You can ping the Engineering Manager or the Product Manager for the relative area to -- cgit v1.2.1 From 4d2cbf7799bf499000dbd7201a50fd7debbfdfba Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Wed, 27 Jun 2018 08:08:51 +0000 Subject: Fix broken links --- PROCESS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 539cc4a243b..43920453722 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -247,12 +247,12 @@ When a regression is found: 1. Create an issue describing the problem in the most detailed way possible 1. If possible, provide links to real examples and how to reproduce the problem 1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels), - the [subject label](../CONTRIBUTING.md#subject-labels-wiki-container-registry-ldap-api-etc) + the [subject label](../CONTRIBUTING.md#subject-labels) and any other label that may apply in the specific case 1. Add the bug and regression labels -1. Notify the respective Engineering Manager to evaluate the Severity of the regression and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels-s1-s2-s3-s4). The counterpart Product Manager is included to weigh-in on prioritization as needed to set the [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels-p1-p2-p3-p4). +1. Notify the respective Engineering Manager to evaluate the Severity of the regression and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels). The counterpart Product Manager is included to weigh-in on prioritization as needed to set the [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels). 1. If the regression is a ~S1 or ~S2, label the regression with the current milestone as it should be fixed in the current milestone. 1. If the regression was introduced in an RC of the current release, label with ~Deliverable 1. If the regression was introduced in the previous release, label with ~"Next Patch Release" -- cgit v1.2.1 From ec126901bbb789d2dac15b59f4a15ddddc4ad392 Mon Sep 17 00:00:00 2001 From: Fabio Busatto Date: Wed, 27 Jun 2018 08:10:29 +0000 Subject: Fix formatting --- PROCESS.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 43920453722..8359f08372a 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -245,17 +245,21 @@ will be scheduled. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible + 1. If possible, provide links to real examples and how to reproduce the problem + 1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels), the [subject label](../CONTRIBUTING.md#subject-labels) and any other label that may apply in the specific case - 1. Add the bug and regression labels + 1. Notify the respective Engineering Manager to evaluate the Severity of the regression and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels). The counterpart Product Manager is included to weigh-in on prioritization as needed to set the [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels). + 1. If the regression is a ~S1 or ~S2, label the regression with the current milestone as it should be fixed in the current milestone. 1. If the regression was introduced in an RC of the current release, label with ~Deliverable 1. If the regression was introduced in the previous release, label with ~"Next Patch Release" + 1. If the regression is a ~S3 or ~S4, the regression may be scheduled for later milestones at the discretion of Engineering Manager and Product Manager. When a new issue is found, the fix should start as soon as possible. You can -- cgit v1.2.1 From 13d9f66496c6f042a96c0cac4b2e63e9dc2cf242 Mon Sep 17 00:00:00 2001 From: Mek Stittri Date: Thu, 28 Jun 2018 09:47:10 -0700 Subject: Fix S3 in the current milestone --- PROCESS.md | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 8359f08372a..d303e895c51 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -245,22 +245,16 @@ will be scheduled. When a regression is found: 1. Create an issue describing the problem in the most detailed way possible - 1. If possible, provide links to real examples and how to reproduce the problem - 1. Label the issue properly, using the [team label](../CONTRIBUTING.md#team-labels), the [subject label](../CONTRIBUTING.md#subject-labels) and any other label that may apply in the specific case - -1. Add the bug and regression labels - +1. Add the ~bug and ~regression labels 1. Notify the respective Engineering Manager to evaluate the Severity of the regression and add a [Severity label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-severity-labels). The counterpart Product Manager is included to weigh-in on prioritization as needed to set the [Priority label](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#bug-priority-labels). - -1. If the regression is a ~S1 or ~S2, label the regression with the current milestone as it should be fixed in the current milestone. +1. If the regression is either an ~S1, ~S2 or ~S3 severity, label the regression with the current milestone as it should be fixed in the current milestone. 1. If the regression was introduced in an RC of the current release, label with ~Deliverable 1. If the regression was introduced in the previous release, label with ~"Next Patch Release" - -1. If the regression is a ~S3 or ~S4, the regression may be scheduled for later milestones at the discretion of Engineering Manager and Product Manager. +1. If the regression is an ~S4 severity, the regression may be scheduled for later milestones at the discretion of Engineering Manager and Product Manager. When a new issue is found, the fix should start as soon as possible. You can ping the Engineering Manager or the Product Manager for the relative area to -- cgit v1.2.1