From 63440e11d6b763a396e9c59928689e81ceb4e166 Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Wed, 8 Feb 2017 19:49:29 +0530 Subject: Set dropdown height fixed to `250px;` and make it scrollable --- app/assets/stylesheets/framework/dropdowns.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/assets/stylesheets/framework/dropdowns.scss b/app/assets/stylesheets/framework/dropdowns.scss index facfb7f9920..8398e9e82a2 100644 --- a/app/assets/stylesheets/framework/dropdowns.scss +++ b/app/assets/stylesheets/framework/dropdowns.scss @@ -127,6 +127,7 @@ z-index: 9; max-width: 280px; min-width: 240px; + max-height: 250px; margin-top: 2px; margin-bottom: 0; font-size: 14px; @@ -136,6 +137,7 @@ border: 1px solid $dropdown-border-color; border-radius: $border-radius-base; box-shadow: 0 2px 4px $dropdown-shadow-color; + overflow-y: auto; &.is-loading { .dropdown-content { -- cgit v1.2.1 From bfc1eda7c8b1ed58ba7344f8a78e524e084b0722 Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Wed, 8 Feb 2017 19:50:23 +0530 Subject: Add changelog entry --- changelogs/unreleased/26206-fix-download-dropdown.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelogs/unreleased/26206-fix-download-dropdown.yml diff --git a/changelogs/unreleased/26206-fix-download-dropdown.yml b/changelogs/unreleased/26206-fix-download-dropdown.yml new file mode 100644 index 00000000000..450df6a2f1b --- /dev/null +++ b/changelogs/unreleased/26206-fix-download-dropdown.yml @@ -0,0 +1,4 @@ +--- +title: Set dropdown height fixed to 250px and make it scrollable +merge_request: +author: -- cgit v1.2.1 From f1dd37ed994b1c73e78c72fce9507c38a9bf2287 Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Wed, 8 Feb 2017 19:57:27 +0530 Subject: Update MR number --- changelogs/unreleased/26206-fix-download-dropdown.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/unreleased/26206-fix-download-dropdown.yml b/changelogs/unreleased/26206-fix-download-dropdown.yml index 450df6a2f1b..a6c101375bb 100644 --- a/changelogs/unreleased/26206-fix-download-dropdown.yml +++ b/changelogs/unreleased/26206-fix-download-dropdown.yml @@ -1,4 +1,4 @@ --- title: Set dropdown height fixed to 250px and make it scrollable -merge_request: +merge_request: 9063 author: -- cgit v1.2.1 From fc425be1a453e8281049c7e00884f6427445176e Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Thu, 9 Feb 2017 13:36:21 +0530 Subject: Fix dropdown height regression --- app/assets/stylesheets/framework/dropdowns.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/assets/stylesheets/framework/dropdowns.scss b/app/assets/stylesheets/framework/dropdowns.scss index 8398e9e82a2..facfb7f9920 100644 --- a/app/assets/stylesheets/framework/dropdowns.scss +++ b/app/assets/stylesheets/framework/dropdowns.scss @@ -127,7 +127,6 @@ z-index: 9; max-width: 280px; min-width: 240px; - max-height: 250px; margin-top: 2px; margin-bottom: 0; font-size: 14px; @@ -137,7 +136,6 @@ border: 1px solid $dropdown-border-color; border-radius: $border-radius-base; box-shadow: 0 2px 4px $dropdown-shadow-color; - overflow-y: auto; &.is-loading { .dropdown-content { -- cgit v1.2.1 From beb56533cb482c3c69cf9d6dcb1c29bb89dcbe6d Mon Sep 17 00:00:00 2001 From: Kushal Pandya Date: Thu, 9 Feb 2017 13:36:51 +0530 Subject: Set dropdown to fixed height of `250px` and make it scrollable --- app/assets/stylesheets/pages/pipelines.scss | 5 +++++ app/assets/stylesheets/pages/projects.scss | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss index 974100bdff0..92e1181bcc0 100644 --- a/app/assets/stylesheets/pages/pipelines.scss +++ b/app/assets/stylesheets/pages/pipelines.scss @@ -218,6 +218,11 @@ } } + .dropdown-menu { + max-height: 250px; + overflow-y: auto; + } + .dropdown-toggle, .dropdown-menu { color: $gl-text-color-secondary; diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index 8b59c20cb65..5a011fdaa8c 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -271,6 +271,13 @@ } } +.project-repo-buttons { + .project-action-button .dropdown-menu { + max-height: 250px; + overflow-y: auto; + } +} + .split-one { display: inline-table; margin-right: 12px; -- cgit v1.2.1