From c46ff7de67d31bfc8875abf58d0fd096b6d725ae Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Mon, 18 Jun 2018 19:00:25 -0500 Subject: Fix flakey time-sensitive specs that rely on notes background Sidekiq jobs Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/48093 We use `perform_enqueued_jobs` because it is "adapter-agnostic so it's better to use it over Sidekiq::Testing.inline!." -- https://gitlab.com/gitlab-org/gitlab-ce/issues/22991 --- spec/support/helpers/features/notes_helpers.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/support/helpers/features/notes_helpers.rb b/spec/support/helpers/features/notes_helpers.rb index 1a1d5853a7a..2b9f8b30c60 100644 --- a/spec/support/helpers/features/notes_helpers.rb +++ b/spec/support/helpers/features/notes_helpers.rb @@ -13,7 +13,7 @@ module Spec module Features module NotesHelpers def add_note(text) - Sidekiq::Testing.fake! do + perform_enqueued_jobs do page.within(".js-main-target-form") do fill_in("note[note]", with: text) find(".js-comment-submit-button").click -- cgit v1.2.1