From c15dc455f12a37713b82a9a2f1e1017d6fbfac5f Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Fri, 19 Aug 2016 14:43:02 +0200 Subject: Move and improvement comment in pipeline fixtures --- db/fixtures/development/14_pipelines.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/db/fixtures/development/14_pipelines.rb b/db/fixtures/development/14_pipelines.rb index 36b0d16bfb9..49e6e2361b1 100644 --- a/db/fixtures/development/14_pipelines.rb +++ b/db/fixtures/development/14_pipelines.rb @@ -74,6 +74,10 @@ class Gitlab::Seeder::Pipelines .merge(commands: '$ build command') Ci::Build.create!(attributes).tap do |build| + # We need to set build trace and artifacts after saving a build + # (id required), that is why we need `#tap` method instead of passing + # block directly to `Ci::Build#create!`. + setup_artifacts(build) setup_build_log(build) build.save @@ -93,11 +97,6 @@ class Gitlab::Seeder::Pipelines end def setup_build_log(build) - ## - # We need to set build trace after saving a build (id required) - # That is why we need `#tap` method instead of passing block - # directly to `Ci::Build#create!`. - # if %w(running success failed).include?(build.status) build.trace = FFaker::Lorem.paragraphs(6).join("\n\n") end -- cgit v1.2.1