From e8648270affc4954f619aa7bd64a2f6e988f8a8a Mon Sep 17 00:00:00 2001 From: Dylan Griffith Date: Tue, 13 Feb 2018 16:08:02 +1100 Subject: Document all_queues.yml in sidekiq_style_guide.md --- doc/development/sidekiq_style_guide.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/development/sidekiq_style_guide.md b/doc/development/sidekiq_style_guide.md index 59ebf41e09f..b3e74fc71cc 100644 --- a/doc/development/sidekiq_style_guide.md +++ b/doc/development/sidekiq_style_guide.md @@ -17,6 +17,9 @@ would be `process_something`. If you're not sure what queue a worker uses, you can find it using `SomeWorker.queue`. There is almost never a reason to manually override the queue name using `sidekiq_options queue: :some_queue`. +You must always add any new queues to `gitlab/app/workers/all_queues.yml` +otherwise your worker will not run. + ## Queue Namespaces While different workers cannot share a queue, they can share a queue namespace. -- cgit v1.2.1 From bbcc18080b90bb21465d8b843f93703eca4a7c6f Mon Sep 17 00:00:00 2001 From: Dylan Griffith Date: Tue, 13 Feb 2018 05:10:04 +0000 Subject: Update sidekiq_style_guide.md --- doc/development/sidekiq_style_guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/development/sidekiq_style_guide.md b/doc/development/sidekiq_style_guide.md index b3e74fc71cc..76ff51446ba 100644 --- a/doc/development/sidekiq_style_guide.md +++ b/doc/development/sidekiq_style_guide.md @@ -17,8 +17,8 @@ would be `process_something`. If you're not sure what queue a worker uses, you can find it using `SomeWorker.queue`. There is almost never a reason to manually override the queue name using `sidekiq_options queue: :some_queue`. -You must always add any new queues to `gitlab/app/workers/all_queues.yml` -otherwise your worker will not run. +You must always add any new queues to `app/workers/all_queues.yml` otherwise +your worker will not run. ## Queue Namespaces -- cgit v1.2.1