From ba1fcfcd5de9f22ff14e0246b17c1fe9d97f6f80 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9my=20Coutable?= <remy@rymai.me>
Date: Mon, 22 Jul 2019 17:50:47 +0200
Subject: Fix usage of 'kubectl create secret generic' in review-apps.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Rémy Coutable <remy@rymai.me>
---
 scripts/review_apps/review-apps.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh
index bc47884ee45..fc9b27d328d 100755
--- a/scripts/review_apps/review-apps.sh
+++ b/scripts/review_apps/review-apps.sh
@@ -156,8 +156,9 @@ function install_external_dns() {
 function create_application_secret() {
   echoinfo "Creating the ${CI_ENVIRONMENT_SLUG}-gitlab-initial-root-password secret in the ${KUBE_NAMESPACE} namespace..." true
 
-  kubectl create secret generic -n "$KUBE_NAMESPACE" \
+  kubectl create secret generic \
     "${CI_ENVIRONMENT_SLUG}-gitlab-initial-root-password" \
+    -n "$KUBE_NAMESPACE" \
     --from-literal="password=${REVIEW_APPS_ROOT_PASSWORD}" \
     --dry-run -o json | kubectl apply -f -
 }
-- 
cgit v1.2.1