From af833d9730dd367984b55ef02ccc3fe6eb83f0e4 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 2 Dec 2022 18:07:23 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .gitignore | 1 + .../lint/constant_definition_in_block.yml | 4 +- .rubocop_todo/performance/bind_call.yml | 10 -- .rubocop_todo/rspec/hooks_before_examples.yml | 26 ---- .../boards/components/board_content.vue | 2 + .../javascripts/boards/components/board_list.vue | 2 + .../boards/components/boards_selector.vue | 2 +- .../bubble_menus/code_block_bubble_menu.vue | 4 +- .../components/suggestions_dropdown.vue | 4 +- app/assets/javascripts/editor/schema/ci.json | 41 +++++- .../components/error_tracking_list.vue | 4 +- app/assets/javascripts/merge_request.js | 2 +- .../pipeline_mini_graph/pipeline_stage.vue | 2 +- .../sidebar/components/lock/issuable_lock_form.vue | 4 +- .../subscriptions/sidebar_subscriptions_widget.vue | 2 +- .../alert_details/components/alert_status.vue | 2 +- .../components/sidebar/sidebar_assignees.vue | 2 +- .../vue_shared/components/actions_button.vue | 2 +- .../listbox_input/listbox_input.stories.js | 26 ++++ .../components/listbox_input/listbox_input.vue | 110 ++++++++++++++++ app/assets/stylesheets/_page_specific_files.scss | 1 - .../stylesheets/components/ref_selector.scss | 2 +- app/assets/stylesheets/framework/dropdowns.scss | 12 +- app/assets/stylesheets/framework/emojis.scss | 4 +- app/assets/stylesheets/framework/header.scss | 2 +- app/assets/stylesheets/framework/typography.scss | 2 +- app/assets/stylesheets/framework/variables.scss | 5 - .../page_bundles/alert_management_details.scss | 2 +- app/assets/stylesheets/page_bundles/clusters.scss | 2 +- .../stylesheets/page_bundles/merge_requests.scss | 4 +- .../stylesheets/page_bundles/oncall_schedules.scss | 2 +- app/assets/stylesheets/pages/monitor.scss | 5 - app/assets/stylesheets/pages/projects.scss | 2 +- app/assets/stylesheets/pages/search.scss | 6 +- app/helpers/listbox_helper.rb | 4 +- app/models/concerns/has_user_type.rb | 16 ++- .../applications/check_progress_service.rb | 50 -------- .../dashboard/grafana_metric_embed_service.rb | 3 +- app/views/admin/projects/index.html.haml | 2 +- app/views/admin/projects/show.html.haml | 2 +- app/views/projects/buttons/_clone.html.haml | 12 +- app/views/projects/buttons/_download.html.haml | 2 +- .../_close_reopen_draft_report_toggle.html.haml | 40 +++--- .../merge_requests/_code_dropdown.html.haml | 34 ++--- .../shared/_new_project_item_select.html.haml | 2 +- app/views/shared/web_hooks/_test_button.html.haml | 6 +- app/workers/all_queues.yml | 20 +-- app/workers/merge_requests/delete_branch_worker.rb | 27 ---- .../merge_requests/delete_source_branch_worker.rb | 9 +- app/workers/projects/delete_branch_worker.rb | 30 +++++ app/workers/run_pipeline_schedule_worker.rb | 2 + config/feature_categories.yml | 1 + .../development/actors_aware_gitaly_calls.yml | 8 -- .../disable_pagination_counts_on_jobs_api.yml | 8 ++ .../development/markdown_image_attributes.yml | 8 ++ .../track_and_raise_delete_source_errors.yml | 8 ++ .../ops/suggested_reviewers_internal_api.yml | 8 ++ config/gitlab.yml.example | 5 + config/initializers/1_settings.rb | 6 + .../gitlab_suggested_reviewers_secret.rb | 5 + config/sidekiq_queues.yml | 4 +- doc/ci/yaml/index.md | 42 +++++++ doc/operations/incident_management/alerts.md | 2 +- .../incident_management/linked_resources.md | 6 +- doc/operations/metrics/alerts.md | 4 +- doc/tutorials/index.md | 2 + doc/user/markdown.md | 27 +++- lib/api/ci/jobs.rb | 4 +- lib/api/internal/kubernetes.rb | 2 +- lib/banzai/filter/attributes_filter.rb | 57 +++++++++ lib/banzai/pipeline/gfm_pipeline.rb | 1 + .../gitaly_client/with_feature_flag_actors.rb | 11 +- lib/gitlab/pagination/offset_pagination.rb | 15 ++- lib/gitlab/patch/prependable.rb | 2 +- locale/gitlab.pot | 15 ++- package.json | 2 +- qa/qa/page/component/dropdown.rb | 10 +- spec/controllers/import/github_controller_spec.rb | 4 +- spec/features/admin/users/users_spec.rb | 4 +- .../alert_management/alert_details_spec.rb | 2 +- spec/features/boards/board_filters_spec.rb | 2 +- spec/features/boards/sidebar_assignee_spec.rb | 2 +- spec/features/groups/board_spec.rb | 2 +- .../incidents/incident_timeline_events_spec.rb | 8 +- spec/features/issuables/shortcuts_issuable_spec.rb | 2 +- spec/features/issues/form_spec.rb | 2 +- spec/features/issues/user_edits_issue_spec.rb | 2 +- spec/features/markdown/markdown_spec.rb | 7 ++ spec/features/projects/compare_spec.rb | 14 +-- .../pages/user_configures_pages_pipeline_spec.rb | 8 +- spec/features/projects/pipeline_schedules_spec.rb | 4 +- .../projects/pipelines/legacy_pipelines_spec.rb | 6 +- spec/features/projects/pipelines/pipelines_spec.rb | 6 +- .../show/user_manages_notifications_spec.rb | 2 +- spec/fixtures/markdown.md.erb | 4 + spec/frontend/boards/board_list_spec.js | 7 ++ .../boards/components/board_content_spec.js | 7 ++ spec/frontend/boards/project_select_spec.js | 2 +- .../__snapshots__/toolbar_link_button_spec.js.snap | 8 +- spec/frontend/editor/schema/ci/ci_schema_spec.js | 4 + .../schema/ci/yaml_tests/negative_tests/hooks.yml | 10 ++ .../schema/ci/yaml_tests/positive_tests/hooks.yml | 10 ++ .../__snapshots__/jira_import_form_spec.js.snap | 20 +-- .../language_switcher/components/app_spec.js | 2 +- .../components/milestone_combobox_spec.js | 4 +- .../__snapshots__/pypi_installation_spec.js.snap | 4 +- .../mr_widget_auto_merge_enabled_spec.js.snap | 4 +- .../__snapshots__/awards_list_spec.js.snap | 2 +- .../components/listbox_input/listbox_input_spec.js | 132 +++++++++++++++++++ .../design_management/design_resolver_spec.rb | 8 +- .../design_management/designs_resolver_spec.rb | 8 +- .../resolvers/project_pipeline_resolver_spec.rb | 8 +- spec/helpers/listbox_helper_spec.rb | 2 +- spec/lib/banzai/filter/attributes_filter_spec.rb | 85 +++++++++++++ .../filter/inline_grafana_metrics_filter_spec.rb | 4 +- .../references/user_reference_filter_spec.rb | 4 +- spec/lib/feature/definition_spec.rb | 10 +- spec/lib/gitlab/auth/saml/user_spec.rb | 8 +- .../email/handler/create_issue_handler_spec.rb | 4 +- .../handler/create_merge_request_handler_spec.rb | 8 +- .../email/handler/create_note_handler_spec.rb | 10 +- .../email/hook/disable_email_interceptor_spec.rb | 8 +- .../gitaly_client/with_feature_flag_actors_spec.rb | 140 ++++++++------------- .../gitlab/pagination/offset_pagination_spec.rb | 22 ++++ spec/lib/gitlab/tracking/event_definition_spec.rb | 10 +- spec/lib/gitlab/usage/metric_definition_spec.rb | 10 +- .../usage_data_counters/hll_redis_counter_spec.rb | 8 +- spec/lib/mattermost/session_spec.rb | 8 +- spec/mailers/notify_spec.rb | 6 +- spec/models/ci/build_trace_chunk_spec.rb | 4 +- spec/models/clusters/applications/ingress_spec.rb | 10 +- spec/models/clusters/applications/knative_spec.rb | 12 +- spec/models/concerns/has_user_type_spec.rb | 3 +- .../chat_message/pipeline_message_spec.rb | 4 +- spec/models/repository_spec.rb | 4 +- spec/requests/api/ci/jobs_spec.rb | 4 +- spec/requests/api/internal/kubernetes_spec.rb | 16 ++- spec/serializers/pipeline_details_entity_spec.rb | 8 +- spec/services/feature_flags/hook_service_spec.rb | 8 +- .../gitlab/delete_tags_service_spec.rb | 8 +- spec/support/helpers/listbox_input_helper.rb | 18 +++ .../patches/rspec_mocks_prepended_methods.rb | 2 +- .../features/content_editor_shared_examples.rb | 2 +- .../sidebar/sidebar_labels_shared_examples.rb | 6 +- .../sidebar/sidebar_milestone_shared_examples.rb | 6 +- .../gitlab/cycle_analytics/deployment_metrics.rb | 8 +- .../merge_requests/delete_branch_worker_spec.rb | 65 ---------- .../delete_source_branch_worker_spec.rb | 23 ++-- spec/workers/pipeline_schedule_worker_spec.rb | 26 ++-- spec/workers/projects/delete_branch_worker_spec.rb | 112 +++++++++++++++++ spec/workers/run_pipeline_schedule_worker_spec.rb | 10 ++ yarn.lock | 8 +- 152 files changed, 1236 insertions(+), 626 deletions(-) delete mode 100644 .rubocop_todo/performance/bind_call.yml create mode 100644 app/assets/javascripts/vue_shared/components/listbox_input/listbox_input.stories.js create mode 100644 app/assets/javascripts/vue_shared/components/listbox_input/listbox_input.vue delete mode 100644 app/assets/stylesheets/pages/monitor.scss delete mode 100644 app/services/clusters/applications/check_progress_service.rb delete mode 100644 app/workers/merge_requests/delete_branch_worker.rb create mode 100644 app/workers/projects/delete_branch_worker.rb delete mode 100644 config/feature_flags/development/actors_aware_gitaly_calls.yml create mode 100644 config/feature_flags/development/disable_pagination_counts_on_jobs_api.yml create mode 100644 config/feature_flags/development/markdown_image_attributes.yml create mode 100644 config/feature_flags/development/track_and_raise_delete_source_errors.yml create mode 100644 config/feature_flags/ops/suggested_reviewers_internal_api.yml create mode 100644 config/initializers/gitlab_suggested_reviewers_secret.rb create mode 100644 lib/banzai/filter/attributes_filter.rb create mode 100644 spec/frontend/editor/schema/ci/yaml_tests/negative_tests/hooks.yml create mode 100644 spec/frontend/editor/schema/ci/yaml_tests/positive_tests/hooks.yml create mode 100644 spec/frontend/vue_shared/components/listbox_input/listbox_input_spec.js create mode 100644 spec/lib/banzai/filter/attributes_filter_spec.rb create mode 100644 spec/support/helpers/listbox_input_helper.rb delete mode 100644 spec/workers/merge_requests/delete_branch_worker_spec.rb create mode 100644 spec/workers/projects/delete_branch_worker_spec.rb diff --git a/.gitignore b/.gitignore index ad7595dc7f2..6441e798332 100644 --- a/.gitignore +++ b/.gitignore @@ -73,6 +73,7 @@ eslint-report.html /.gitlab_workhorse_secret /.gitlab_pages_secret /.gitlab_kas_secret +/.gitlab_suggested_reviewers_secret /webpack-report/ /crystalball/ /test_results/ diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index 813e0b22559..ff3f6b2afbc 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -1,8 +1,6 @@ --- Lint/ConstantDefinitionInBlock: - # Offense count: 111 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/partitioned_table.rb' diff --git a/.rubocop_todo/performance/bind_call.yml b/.rubocop_todo/performance/bind_call.yml deleted file mode 100644 index 732aecc3910..00000000000 --- a/.rubocop_todo/performance/bind_call.yml +++ /dev/null @@ -1,10 +0,0 @@ ---- -# Cop supports --autocorrect. -Performance/BindCall: - Exclude: - - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' - - 'ee/spec/features/issues/form_spec.rb' - - 'lib/gitlab/patch/prependable.rb' - - 'spec/features/issues/form_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/support/patches/rspec_mocks_prepended_methods.rb' diff --git a/.rubocop_todo/rspec/hooks_before_examples.yml b/.rubocop_todo/rspec/hooks_before_examples.yml index 01756f4d8c3..333687e1cc4 100644 --- a/.rubocop_todo/rspec/hooks_before_examples.yml +++ b/.rubocop_todo/rspec/hooks_before_examples.yml @@ -44,29 +44,3 @@ RSpec/HooksBeforeExamples: - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/spec/resource/reusable_collection_spec.rb' - 'qa/spec/specs/runner_spec.rb' - - 'spec/controllers/import/github_controller_spec.rb' - - 'spec/features/projects/pages/user_configures_pages_pipeline_spec.rb' - - 'spec/graphql/resolvers/design_management/design_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/designs_resolver_spec.rb' - - 'spec/graphql/resolvers/project_pipeline_resolver_spec.rb' - - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/feature/definition_spec.rb' - - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/email/handler/create_issue_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_merge_request_handler_spec.rb' - - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - - 'spec/lib/gitlab/email/hook/disable_email_interceptor_spec.rb' - - 'spec/lib/gitlab/tracking/event_definition_spec.rb' - - 'spec/lib/gitlab/usage/metric_definition_spec.rb' - - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' - - 'spec/lib/mattermost/session_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/clusters/applications/ingress_spec.rb' - - 'spec/models/clusters/applications/knative_spec.rb' - - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/serializers/pipeline_details_entity_spec.rb' - - 'spec/services/feature_flags/hook_service_spec.rb' - - 'spec/services/projects/container_repository/gitlab/delete_tags_service_spec.rb' - - 'spec/support/shared_examples/lib/gitlab/cycle_analytics/deployment_metrics.rb' diff --git a/app/assets/javascripts/boards/components/board_content.vue b/app/assets/javascripts/boards/components/board_content.vue index 5bc6ce105b9..ca86894ca40 100644 --- a/app/assets/javascripts/boards/components/board_content.vue +++ b/app/assets/javascripts/boards/components/board_content.vue @@ -116,6 +116,8 @@ export default { group: 'boards-list', tag: 'div', value: this.boardListsToUse, + delay: 100, + delayOnTouchOnly: true, }; return this.canDragColumns ? options : {}; diff --git a/app/assets/javascripts/boards/components/board_list.vue b/app/assets/javascripts/boards/components/board_list.vue index 6561958b9bf..215691c7ba2 100644 --- a/app/assets/javascripts/boards/components/board_list.vue +++ b/app/assets/javascripts/boards/components/board_list.vue @@ -133,6 +133,8 @@ export default { 'ghost-class': 'board-card-drag-active', 'data-list-id': this.list.id, value: this.boardItems, + delay: 100, + delayOnTouchOnly: true, }; return this.canMoveIssue ? options : {}; diff --git a/app/assets/javascripts/boards/components/boards_selector.vue b/app/assets/javascripts/boards/components/boards_selector.vue index eaf3facb450..4f90d77c0be 100644 --- a/app/assets/javascripts/boards/components/boards_selector.vue +++ b/app/assets/javascripts/boards/components/boards_selector.vue @@ -237,7 +237,7 @@ export default { :text="board.name" @show="loadBoards" > -

+

{{ s__('IssueBoards|Switch board') }}

diff --git a/app/assets/javascripts/content_editor/components/bubble_menus/code_block_bubble_menu.vue b/app/assets/javascripts/content_editor/components/bubble_menus/code_block_bubble_menu.vue index a9668ebdb69..98b7203778f 100644 --- a/app/assets/javascripts/content_editor/components/bubble_menus/code_block_bubble_menu.vue +++ b/app/assets/javascripts/content_editor/components/bubble_menus/code_block_bubble_menu.vue @@ -166,9 +166,7 @@ export default { icon="arrow-left" @click.prevent.stop="showCustomLanguageInput = false" /> -

+

{{ __('Create custom type') }}

diff --git a/app/assets/javascripts/content_editor/components/suggestions_dropdown.vue b/app/assets/javascripts/content_editor/components/suggestions_dropdown.vue index 001b34a00fa..37e6ef61d50 100644 --- a/app/assets/javascripts/content_editor/components/suggestions_dropdown.vue +++ b/app/assets/javascripts/content_editor/components/suggestions_dropdown.vue @@ -210,10 +210,10 @@ export default {