From ad2d90fb2475c9660b04951cd93ee969cf78c09b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 10 Mar 2023 15:11:00 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/preflight.gitlab-ci.yml | 47 ++++- .gitlab/ci/qa.gitlab-ci.yml | 13 -- .gitlab/ci/setup.gitlab-ci.yml | 16 -- .../dashboard/components/issues_dashboard_app.vue | 20 +- .../general/components/signup_form.vue | 21 +- app/assets/javascripts/sentry/constants.js | 46 ----- app/assets/javascripts/sentry/legacy_constants.js | 46 +++++ .../javascripts/sentry/legacy_sentry_config.js | 2 +- app/assets/javascripts/sentry/sentry_config.js | 4 - app/controllers/concerns/confirm_email_warning.rb | 2 +- app/controllers/confirmations_controller.rb | 2 +- .../registrations/welcome_controller.rb | 2 +- app/controllers/registrations_controller.rb | 4 +- app/models/application_setting.rb | 27 +++ app/models/project.rb | 1 + app/models/service_desk.rb | 7 + .../service_desk/custom_email_verification.rb | 55 ++++++ app/models/service_desk_setting.rb | 25 ++- app/models/user.rb | 17 +- .../bulk_imports/archive_extraction_service.rb | 11 -- app/services/ci/job_artifacts/create_service.rb | 8 +- .../_visibility_and_access.html.haml | 2 + app/views/shared/issuable/_feed_buttons.html.haml | 8 +- .../service_desk_custom_email_verifications.yml | 11 ++ ..._add_service_desk_custom_email_verifications.rb | 24 +++ ..._add_saml_group_lock_to_application_settings.rb | 7 + ..._queue_delete_orphaned_packages_dependencies.rb | 26 +++ ...0111859_recreate_user_type_migration_indexes.rb | 24 +++ db/schema_migrations/20230118135145 | 1 + db/schema_migrations/20230224161346 | 1 + db/schema_migrations/20230303105806 | 1 + db/schema_migrations/20230310111859 | 1 + db/structure.sql | 28 ++- doc/administration/geo/secondary_proxy/index.md | 1 + doc/administration/operations/index.md | 1 + .../postgresql/multiple_databases.md | 2 +- doc/api/pipeline_triggers.md | 2 +- doc/ci/pipelines/downstream_pipelines.md | 30 ++- .../img/multi_project_pipeline_graph_v14_3.png | Bin 30119 -> 0 bytes doc/ci/pipelines/img/pipeline_mini_graph_v15_0.png | Bin 6061 -> 0 bytes doc/ci/pipelines/index.md | 3 +- doc/ci/yaml/index.md | 6 +- doc/development/contributing/style_guides.md | 22 ++- doc/development/database/multiple_databases.md | 2 +- doc/development/gemfile.md | 2 + doc/integration/advanced_search/elasticsearch.md | 1 + doc/update/index.md | 9 +- .../admin_area/settings/sign_up_restrictions.md | 48 ++--- doc/user/group/saml_sso/group_sync.md | 24 +++ doc/user/packages/npm_registry/index.md | 29 ++- doc/user/search/advanced_search.md | 2 + lefthook.yml | 25 +++ .../delete_orphaned_packages_dependencies.rb | 27 +++ lib/gitlab/import_export/command_line_util.rb | 14 ++ lib/gitlab/import_export/file_importer.rb | 17 +- locale/gitlab.pot | 29 ++- .../concerns/confirm_email_warning_spec.rb | 2 +- spec/controllers/confirmations_controller_spec.rb | 66 ++++--- .../omniauth_callbacks_controller_spec.rb | 28 ++- .../registrations/welcome_controller_spec.rb | 26 +++ spec/controllers/registrations_controller_spec.rb | 216 ++++++++++----------- spec/factories/ci/builds.rb | 10 +- .../service_desk/custom_email_verification.rb | 8 + spec/features/invites_spec.rb | 7 +- spec/features/users/login_spec.rb | 13 +- spec/features/users/signup_spec.rb | 7 +- spec/frontend/sentry/sentry_config_spec.js | 7 - .../delete_orphaned_packages_dependencies_spec.rb | 57 ++++++ spec/lib/gitlab/import_export/all_models.yml | 3 + .../gitlab/import_export/command_line_util_spec.rb | 61 ++++-- ...e_delete_orphaned_packages_dependencies_spec.rb | 26 +++ spec/models/application_setting_spec.rb | 46 +++++ spec/models/ci/build_spec.rb | 2 +- spec/models/project_spec.rb | 1 + .../service_desk/custom_email_verification_spec.rb | 109 +++++++++++ spec/models/service_desk_setting_spec.rb | 57 +++++- spec/models/user_spec.rb | 94 +++++++-- spec/policies/global_policy_spec.rb | 3 + spec/requests/api/ci/job_artifacts_spec.rb | 6 +- spec/requests/api/oauth_tokens_spec.rb | 2 + spec/serializers/build_details_entity_spec.rb | 2 +- .../ci/job_artifacts/create_service_spec.rb | 143 ++++++++------ .../secure_oauth_authorizations_shared_examples.rb | 2 +- 83 files changed, 1325 insertions(+), 485 deletions(-) delete mode 100644 app/assets/javascripts/sentry/constants.js create mode 100644 app/assets/javascripts/sentry/legacy_constants.js create mode 100644 app/models/service_desk.rb create mode 100644 app/models/service_desk/custom_email_verification.rb create mode 100644 db/docs/service_desk_custom_email_verifications.yml create mode 100644 db/migrate/20230118135145_add_service_desk_custom_email_verifications.rb create mode 100644 db/migrate/20230224161346_add_saml_group_lock_to_application_settings.rb create mode 100644 db/post_migrate/20230303105806_queue_delete_orphaned_packages_dependencies.rb create mode 100644 db/post_migrate/20230310111859_recreate_user_type_migration_indexes.rb create mode 100644 db/schema_migrations/20230118135145 create mode 100644 db/schema_migrations/20230224161346 create mode 100644 db/schema_migrations/20230303105806 create mode 100644 db/schema_migrations/20230310111859 delete mode 100644 doc/ci/pipelines/img/multi_project_pipeline_graph_v14_3.png delete mode 100644 doc/ci/pipelines/img/pipeline_mini_graph_v15_0.png create mode 100644 lib/gitlab/background_migration/delete_orphaned_packages_dependencies.rb create mode 100644 spec/factories/service_desk/custom_email_verification.rb create mode 100644 spec/lib/gitlab/background_migration/delete_orphaned_packages_dependencies_spec.rb create mode 100644 spec/migrations/20230303105806_queue_delete_orphaned_packages_dependencies_spec.rb create mode 100644 spec/models/service_desk/custom_email_verification_spec.rb diff --git a/.gitlab/ci/preflight.gitlab-ci.yml b/.gitlab/ci/preflight.gitlab-ci.yml index 05b05fde53b..464eac56a95 100644 --- a/.gitlab/ci/preflight.gitlab-ci.yml +++ b/.gitlab/ci/preflight.gitlab-ci.yml @@ -1,14 +1,59 @@ +.preflight-job-base: + stage: preflight + extends: + - .default-retry + needs: [] + +.qa-preflight-job: + image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/debian-bullseye-ruby-${RUBY_VERSION}:bundler-2.3-chrome-${CHROME_VERSION}-docker-${DOCKER_VERSION} + extends: + - .preflight-job-base + - .qa-cache + variables: + USE_BUNDLE_INSTALL: "false" + SETUP_DB: "false" + before_script: + - !reference [.default-before_script, before_script] + - cd qa && bundle install + rails-production-environment: extends: + - .preflight-job-base - .default-before_script - .production - .ruby-cache - .setup:rules:rails-production-environment - .use-pg12 - stage: preflight variables: BUNDLE_WITHOUT: "development:test" BUNDLE_WITH: "production" needs: [] script: - bundle exec rails runner --environment=production 'puts Rails.env' + +no-ee-check: + extends: + - .preflight-job-base + - .setup:rules:no-ee-check + script: + - scripts/no-dir-check ee + +no-jh-check: + extends: + - .preflight-job-base + - .setup:rules:no-jh-check + script: + - scripts/no-dir-check jh + +qa:selectors: + extends: + - .qa-preflight-job + - .qa:rules:ee-and-foss + script: + - bundle exec bin/qa Test::Sanity::Selectors + +qa:selectors-as-if-foss: + extends: + - qa:selectors + - .qa:rules:as-if-foss + - .as-if-foss diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 95ae215d134..97f8820a511 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -25,13 +25,6 @@ qa:internal-as-if-foss: - .qa:rules:internal-as-if-foss - .as-if-foss -qa:selectors: - extends: - - .qa-job-base - - .qa:rules:ee-and-foss - script: - - bundle exec bin/qa Test::Sanity::Selectors - qa:master-auto-quarantine-dequarantine: extends: - .qa-job-base @@ -50,12 +43,6 @@ qa:nightly-auto-quarantine-dequarantine: - bundle exec confiner -r .confiner/nightly.yml allow_failure: true -qa:selectors-as-if-foss: - extends: - - qa:selectors - - .qa:rules:as-if-foss - - .as-if-foss - qa:update-qa-cache: extends: - .qa-job-base diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 298d5c4ae08..76c7af2753e 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -51,22 +51,6 @@ gitlab_git_test: script: - spec/support/prepare-gitlab-git-test-for-commit --check-for-changes -no-ee-check: - extends: - - .predictive-job - - .setup:rules:no-ee-check - stage: test - script: - - scripts/no-dir-check ee - -no-jh-check: - extends: - - .predictive-job - - .setup:rules:no-jh-check - stage: test - script: - - scripts/no-dir-check jh - verify-ruby-3.0: extends: - .absolutely-predictive-job diff --git a/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue b/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue index c15cf492e06..ad727f01bab 100644 --- a/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue +++ b/app/assets/javascripts/issues/dashboard/components/issues_dashboard_app.vue @@ -459,12 +459,20 @@ export default { @sort="handleSort" >