From a45f7262f9a3e26361b6fde4f77d0d27437535cf Mon Sep 17 00:00:00 2001 From: "C. Morgan Hamill" Date: Wed, 7 May 2014 16:41:35 -0400 Subject: Clean up of `name` fallback code. Don't use `unless` for the conditional. Avoid double-quotes where possible. --- lib/gitlab/oauth/user.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/gitlab/oauth/user.rb b/lib/gitlab/oauth/user.rb index c6f56c141e5..e9e57aa5742 100644 --- a/lib/gitlab/oauth/user.rb +++ b/lib/gitlab/oauth/user.rb @@ -65,10 +65,10 @@ module Gitlab end def name - unless auth.info.name.nil? - auth.info.name.to_s.force_encoding("utf-8") + if !auth.info.name.nil? + auth.info.name.to_s.force_encoding('utf-8') else - "#{auth.info.first_name} #{auth.info.last_name}".force_encoding("utf-8") + "#{auth.info.first_name} #{auth.info.last_name}".force_encoding('utf-8') end end -- cgit v1.2.1