From a3edd473b936de0be841c003506a41e0ff941b9e Mon Sep 17 00:00:00 2001 From: Douwe Maan Date: Sat, 9 May 2015 23:51:50 +0200 Subject: Improve create_mr_button? performance. --- app/helpers/compare_helper.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/helpers/compare_helper.rb b/app/helpers/compare_helper.rb index fe339d32155..f1dc906cab4 100644 --- a/app/helpers/compare_helper.rb +++ b/app/helpers/compare_helper.rb @@ -1,12 +1,11 @@ module CompareHelper def create_mr_button?(from = params[:from], to = params[:to], project = @project) - project.merge_requests_enabled && - from.present? && + from.present? && to.present? && - project.repository.branch_names.include?(from) && - project.repository.branch_names.include?(to) && from != to && - !@refs_are_same + project.merge_requests_enabled && + project.repository.branch_names.include?(from) && + project.repository.branch_names.include?(to) end def create_mr_path(from = params[:from], to = params[:to], project = @project) -- cgit v1.2.1