From a19c83dd7aa35ea79473d3cfc73bdcdc0dca5ec0 Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Fri, 9 Nov 2018 14:46:15 +0000 Subject: Consistently use Vue.nexTick when starting taskList --- app/assets/javascripts/notes/stores/actions.js | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/notes/stores/actions.js b/app/assets/javascripts/notes/stores/actions.js index 9ecb2bc8f52..a4ab079d258 100644 --- a/app/assets/javascripts/notes/stores/actions.js +++ b/app/assets/javascripts/notes/stores/actions.js @@ -66,7 +66,7 @@ export const updateNote = ({ commit, dispatch }, { endpoint, note }) => .then(res => res.json()) .then(res => { commit(types.UPDATE_NOTE, res); - Vue.nextTick(() => dispatch('startTaskList')); + dispatch('startTaskList'); }); export const replyToDiscussion = ({ commit }, { endpoint, data }) => @@ -265,7 +265,7 @@ const pollSuccessCallBack = (resp, commit, state, getters, dispatch) => { } }); - Vue.nextTick(() => dispatch('startTaskList')); + dispatch('startTaskList'); } commit(types.SET_LAST_FETCHED_AT, resp.last_fetched_at); @@ -375,12 +375,15 @@ export const setCommentsDisabled = ({ commit }, data) => { }; export const startTaskList = ({ dispatch }) => - new TaskList({ - dataType: 'note', - fieldName: 'note', - selector: '.notes .is-editable', - onSuccess: () => Vue.nextTick(() => dispatch('startTaskList')), - }); + Vue.nextTick( + () => + new TaskList({ + dataType: 'note', + fieldName: 'note', + selector: '.notes .is-editable', + onSuccess: () => dispatch('startTaskList'), + }), + ); // prevent babel-plugin-rewire from generating an invalid default during karma tests export default () => {}; -- cgit v1.2.1